chore(dep): fix expo sample version to 52.0.19 - #4592

Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from
antonis/sample-expo-version
Closed

chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from
antonis/sample-expo-version

Conversation

@antonis

@antonisantonis commented Feb 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #4568

📜 Description

Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.

e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context

Ci failures

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis

antonis commented Feb 25, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Note that the type test failures are fixed by #4587

@antonisantonis changed the title chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis marked this pull request as ready for review February 25, 2025 09:04
@github-actions

github-actionsBot commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms

App size

RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB

@github-actions

github-actionsBot commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms

App size

RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB

@github-actions

github-actionsBot commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms

App size

RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB

@github-actions

github-actionsBot commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB

Baseline results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms

App size

RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB

krystofwoldrich
krystofwoldrich approved these changes Feb 25, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.

When have we updated to 52.0.37 as this is not an issue on main at the moment?

@krystofwoldrich

krystofwoldrich commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

I see it's coming from #4568

We should check the yarn.lock changes, there should not be so many changes.

@krystofwoldrichkrystofwoldrich mentioned this pull request Feb 25, 2025
Merged
12 tasks
@antonis

antonis commented Feb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

When have we updated to 52.0.37

I've tested 52.0.37 and the issue persists.

as this is not an issue on main at the moment?

I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔

@krystofwoldrich

krystofwoldrich commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Yes, we should avoid updating unrelated deps in #4568

After the yarn.lock is fixed in #4568 this PR should not be needed.

@antonis

antonis commented Feb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Closing as per #4592 (comment)

@antonisantonis closed this Feb 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(dep): fix expo sample version to 52.0.19 - #4592
Closed
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Closed
chore(dep): fix expo sample version to 52.0.19#4592
antonis wants to merge 1 commit into
lz/bump/jsv9from 
antonis/sample-expo-version
Conversation
@antonis
@antonisantonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on #4568
📜 Description
Fixes Expo sample version to 52.0.19 to avoid Expo sample Kotlin Version build failure.
e: This version (1.5.15) of the Compose Compiler requires Kotlin version 1.9.25 but you appear to be using Kotlin version 1.9.24 which is not known to be compatible. Please consult the Compose-Kotlin compatibility map located at https://developer.android.com/jetpack/androidx/releases/compose-kotlin to choose a compatible version pair (or suppressKotlinVersionCompatibilityCheck but don't say I didn't warn you!).

💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonis
antonis
commented
Feb 25, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Note that the type test failures are fixed by #4587
@antonisantonis
changed the title
chore(dep): fix expo version to 52.0.19chore(dep): fix expo sample version to 52.0.19Feb 25, 2025
@antonis
antonis
marked this pull request as ready for review
February 25, 2025 09:04
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time370.15 ms398.72 ms28.58 ms
Size17.75 MiB20.10 MiB2.36 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
71f7309412.45 ms431.62 ms19.18 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
345e497397.98 ms423.40 ms25.42 ms
App size
RevisionPlainWith SentryDiff
71f730917.75 MiB20.10 MiB2.36 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1206.62 ms1213.94 ms7.32 ms
Size2.63 MiB3.73 MiB1.10 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time356.45 ms349.43 ms-7.02 ms
Size7.15 MiB8.37 MiB1.22 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
App size
RevisionPlainWith SentryDiff
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1226.62 ms1221.76 ms-4.87 ms
Size3.19 MiB4.30 MiB1.11 MiB
Baseline results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
App size
RevisionPlainWith SentryDiff
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
krystofwoldrich
krystofwoldrich
approved these changes
Feb 25, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
I see it's coming from #4568
We should check the yarn.lock changes, there should not be so many changes.
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Feb 25, 2025
 Merged

12 tasks
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
When have we updated to 52.0.37
I've tested 52.0.37 and the issue persists.
as this is not an issue on main at the moment?
I was not able to reproduce the issue on main or v7 and is probably triggered by a dependency changes in #4568 🤔
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Yes, we should avoid updating unrelated deps in #4568
After the yarn.lock is fixed in #4568 this PR should not be needed.
@antonis
antonis
commented
Feb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as per #4592 (comment)
@antonisantonis
closed this
Feb 25, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich