Skip to content

Fix(V7): missing ip settings from SDK package - #5093

Closed
lucas-zimerman wants to merge 5 commits into
v7from
lz/fiz-v7-ip
Closed

Fix(V7): missing ip settings from SDK package#5093
lucas-zimerman wants to merge 5 commits into
v7from
lz/fiz-v7-ip

Conversation

@lucas-zimerman

@lucas-zimermanlucas-zimerman commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Based on getsentry/sentry-javascript#17364

original context;

This PR fixes a long-standing problem in the SDK where it would set incorrect information about when Relay should (not) infer IP addresses from sent envelope requests.
Previously, this was thought to be controlled by setting event.user.ip_address: '{{auto}}'. However, after an incident in Relay, it was determined that this is in fact not a reliably way to control IP inference. Instead, SDKs should set event.sdk.settings.infer_ip: 'auto' | 'never' (see closes https://github.com/getsentry/sentry-javascript/issues/16252).
Unfortunately, this wasn't implemented immediately but is taken care of in this PR.
(FWIW, the only reason why Relay continued to infer IP addresses for the JS SDK was because it is excempt from logic that would infer IP addresses only if user.ip_address was set to '{{auto}}'. This is necessary to backwards compatibility with older SDKs.)
Follow-ups: We likely also need to adjust the logic in Electron and Lynx (at the very least remove setting user.ip_address).
closes https://github.com/getsentry/sentry-javascript/issues/17351
closes https://github.com/getsentry/sentry-javascript/issues/16252

Instead of bumping o V10, the fix was patched on the current release.

@lucas-zimermanlucas-zimerman changed the title Lz/fiz v7 ip Fix(V7): missing ip settings from SDK packageAug 20, 2025
@lucas-zimerman
lucas-zimerman changed the base branch from main to v7August 20, 2025 15:55
lucas-zimerman
lucas-zimerman commented Aug 20, 2025
View reviewed changes
Comment threadCHANGELOG.md Outdated
@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time349.30 ms383.80 ms34.49 ms
Size7.15 MiB8.37 MiB1.22 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
0e27665+dirty355.91 ms422.52 ms66.61 ms
7eff2d7+dirty393.13 ms426.77 ms33.65 ms
f870f2d+dirty398.49 ms434.24 ms35.75 ms
26515b5+dirty389.83 ms443.94 ms54.11 ms
472960b+dirty394.39 ms376.18 ms-18.20 ms
11cc947+dirty385.96 ms420.08 ms34.12 ms
20d0171+dirty380.17 ms422.57 ms42.40 ms
c26618b+dirty354.44 ms414.73 ms60.29 ms
10ec2e1+dirty373.87 ms443.64 ms69.78 ms
3c99746+dirty400.65 ms399.59 ms-1.06 ms

App size

RevisionPlainWith SentryDiff
0e27665+dirty7.15 MiB8.35 MiB1.20 MiB
7eff2d7+dirty7.15 MiB8.35 MiB1.20 MiB
f870f2d+dirty7.15 MiB8.34 MiB1.18 MiB
26515b5+dirty7.15 MiB8.36 MiB1.21 MiB
472960b+dirty7.15 MiB8.34 MiB1.18 MiB
11cc947+dirty7.15 MiB8.36 MiB1.20 MiB
20d0171+dirty7.15 MiB8.35 MiB1.20 MiB
c26618b+dirty7.15 MiB8.36 MiB1.20 MiB
10ec2e1+dirty7.15 MiB8.35 MiB1.20 MiB
3c99746+dirty7.15 MiB8.34 MiB1.18 MiB

@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1210.11 ms1210.40 ms0.28 ms
Size3.19 MiB4.39 MiB1.20 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
c26618b+dirty1228.54 ms1236.52 ms7.98 ms
0e27665+dirty1207.12 ms1220.33 ms13.20 ms
20d0171+dirty1214.21 ms1220.31 ms6.10 ms
472960b+dirty1243.67 ms1233.57 ms-10.11 ms
26515b5+dirty1216.98 ms1224.24 ms7.27 ms
fb47c4a+dirty1243.40 ms1245.86 ms2.46 ms
7eff2d7+dirty1224.84 ms1227.94 ms3.10 ms
11cc947+dirty1218.92 ms1234.24 ms15.33 ms
10ec2e1+dirty1229.04 ms1222.28 ms-6.76 ms
3c99746+dirty1227.65 ms1228.81 ms1.16 ms

App size

RevisionPlainWith SentryDiff
c26618b+dirty3.19 MiB4.39 MiB1.20 MiB
0e27665+dirty3.19 MiB4.37 MiB1.18 MiB
20d0171+dirty3.19 MiB4.37 MiB1.18 MiB
472960b+dirty3.19 MiB4.36 MiB1.17 MiB
26515b5+dirty3.19 MiB4.39 MiB1.20 MiB
fb47c4a+dirty3.19 MiB4.37 MiB1.18 MiB
7eff2d7+dirty3.19 MiB4.36 MiB1.17 MiB
11cc947+dirty3.19 MiB4.39 MiB1.20 MiB
10ec2e1+dirty3.19 MiB4.39 MiB1.20 MiB
3c99746+dirty3.19 MiB4.35 MiB1.16 MiB

@lucas-zimerman
lucas-zimerman marked this pull request as ready for review August 25, 2025 14:50
@lucas-zimerman

lucas-zimerman commented Aug 25, 2025

Copy link
Copy Markdown
CollaboratorAuthor

iOS errors are from v7 branch.

@antonis

antonis commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

iOS errors are from v7 branch.

I've merged the latest from v7 were the errors should now be fixed 🤞
Let's keep this as a fallback to #5111 for now.

@github-actions

github-actionsBot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.60 ms1210.58 ms-12.03 ms
Size2.63 MiB3.83 MiB1.19 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
c26618b+dirty1230.06 ms1233.30 ms3.24 ms
0e27665+dirty1213.52 ms1237.61 ms24.09 ms
20d0171+dirty1214.96 ms1215.20 ms0.25 ms
472960b+dirty1213.96 ms1222.58 ms8.62 ms
26515b5+dirty1240.49 ms1237.19 ms-3.30 ms
fb47c4a+dirty1231.00 ms1231.33 ms0.33 ms
7eff2d7+dirty1225.34 ms1234.53 ms9.19 ms
11cc947+dirty1239.65 ms1239.64 ms-0.01 ms
10ec2e1+dirty1228.02 ms1237.54 ms9.52 ms
3c99746+dirty1215.12 ms1222.31 ms7.18 ms

App size

RevisionPlainWith SentryDiff
c26618b+dirty2.63 MiB3.82 MiB1.19 MiB
0e27665+dirty2.63 MiB3.80 MiB1.17 MiB
20d0171+dirty2.63 MiB3.80 MiB1.17 MiB
472960b+dirty2.63 MiB3.79 MiB1.15 MiB
26515b5+dirty2.63 MiB3.83 MiB1.19 MiB
fb47c4a+dirty2.63 MiB3.80 MiB1.17 MiB
7eff2d7+dirty2.63 MiB3.79 MiB1.16 MiB
11cc947+dirty2.63 MiB3.82 MiB1.19 MiB
10ec2e1+dirty2.63 MiB3.82 MiB1.19 MiB
3c99746+dirty2.63 MiB3.78 MiB1.15 MiB

@github-actions

github-actionsBot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time365.92 ms382.48 ms16.56 ms
Size17.75 MiB19.64 MiB1.90 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
10ec2e1435.28 ms431.58 ms-3.70 ms
472960b418.84 ms405.38 ms-13.46 ms
11cc947501.96 ms486.04 ms-15.92 ms
0e27665356.27 ms367.74 ms11.47 ms
7eff2d7420.64 ms401.86 ms-18.78 ms
fb47c4a435.33 ms434.94 ms-0.40 ms
f870f2d444.67 ms449.62 ms4.95 ms
26515b5446.24 ms441.91 ms-4.33 ms
20d0171366.62 ms366.43 ms-0.19 ms
c26618b435.76 ms430.14 ms-5.62 ms

App size

RevisionPlainWith SentryDiff
10ec2e117.75 MiB19.60 MiB1.85 MiB
472960b17.75 MiB19.58 MiB1.83 MiB
11cc94717.75 MiB19.60 MiB1.86 MiB
0e2766517.75 MiB19.60 MiB1.85 MiB
7eff2d717.75 MiB19.60 MiB1.85 MiB
fb47c4a17.75 MiB19.60 MiB1.85 MiB
f870f2d17.75 MiB19.58 MiB1.83 MiB
26515b517.75 MiB19.60 MiB1.86 MiB
20d017117.75 MiB19.60 MiB1.85 MiB
c26618b17.75 MiB19.60 MiB1.85 MiB

@antonis

antonis commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

@lucas-zimerman I'm closing this now that JS10 is merged with #5111. Thank you for preparing this PR 🙇

@antonisantonis closed this Aug 29, 2025
@lucas-zimermanlucas-zimerman mentioned this pull request Sep 3, 2025
Merged
10 tasks
@lucas-zimerman
lucas-zimerman requested review from Lms24 and removed request for Lms24September 3, 2025 09:30
@lucas-zimerman
lucas-zimerman deleted the lz/fiz-v7-ip branch March 2, 2026 17:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonisantonisAwaiting requested review from antonis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucas-zimerman@antonis