Skip to content

chore(deps): v7: update JavaScript SDK to v10 - #5111

Merged
antonis merged 16 commits into
v7from
antonis/bump-js10
Aug 28, 2025
Merged

chore(deps): v7: update JavaScript SDK to v10#5111
antonis merged 16 commits into
v7from
antonis/bump-js10

Conversation

@antonis

@antonisantonis commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps JS SDK to 10.7.0. Some refactoring was needed due to:

💡 Motivation and Context

JS 10 https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#1000

https://docs.sentry.io/platforms/javascript/migration/v9-to-v10/

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions

github-actionsBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time409.94 ms396.04 ms-13.90 ms
Size17.75 MiB19.68 MiB1.93 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
10ec2e1435.28 ms431.58 ms-3.70 ms
472960b418.84 ms405.38 ms-13.46 ms
11cc947501.96 ms486.04 ms-15.92 ms
0e27665356.27 ms367.74 ms11.47 ms
7eff2d7420.64 ms401.86 ms-18.78 ms
fb47c4a435.33 ms434.94 ms-0.40 ms
f870f2d444.67 ms449.62 ms4.95 ms
26515b5446.24 ms441.91 ms-4.33 ms
20d0171366.62 ms366.43 ms-0.19 ms
c26618b435.76 ms430.14 ms-5.62 ms

App size

RevisionPlainWith SentryDiff
10ec2e117.75 MiB19.60 MiB1.85 MiB
472960b17.75 MiB19.58 MiB1.83 MiB
11cc94717.75 MiB19.60 MiB1.86 MiB
0e2766517.75 MiB19.60 MiB1.85 MiB
7eff2d717.75 MiB19.60 MiB1.85 MiB
fb47c4a17.75 MiB19.60 MiB1.85 MiB
f870f2d17.75 MiB19.58 MiB1.83 MiB
26515b517.75 MiB19.60 MiB1.86 MiB
20d017117.75 MiB19.60 MiB1.85 MiB
c26618b17.75 MiB19.60 MiB1.85 MiB

Previous results on branch: antonis/bump-js10

Startup times

RevisionPlainWith SentryDiff
aeced70413.43 ms405.10 ms-8.33 ms

App size

RevisionPlainWith SentryDiff
aeced7017.75 MiB19.68 MiB1.93 MiB

@github-actions

github-actionsBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1217.65 ms1227.16 ms9.51 ms
Size2.63 MiB3.87 MiB1.24 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
c26618b+dirty1230.06 ms1233.30 ms3.24 ms
0e27665+dirty1213.52 ms1237.61 ms24.09 ms
20d0171+dirty1214.96 ms1215.20 ms0.25 ms
472960b+dirty1213.96 ms1222.58 ms8.62 ms
26515b5+dirty1240.49 ms1237.19 ms-3.30 ms
fb47c4a+dirty1231.00 ms1231.33 ms0.33 ms
7eff2d7+dirty1225.34 ms1234.53 ms9.19 ms
11cc947+dirty1239.65 ms1239.64 ms-0.01 ms
10ec2e1+dirty1228.02 ms1237.54 ms9.52 ms
3c99746+dirty1215.12 ms1222.31 ms7.18 ms

App size

RevisionPlainWith SentryDiff
c26618b+dirty2.63 MiB3.82 MiB1.19 MiB
0e27665+dirty2.63 MiB3.80 MiB1.17 MiB
20d0171+dirty2.63 MiB3.80 MiB1.17 MiB
472960b+dirty2.63 MiB3.79 MiB1.15 MiB
26515b5+dirty2.63 MiB3.83 MiB1.19 MiB
fb47c4a+dirty2.63 MiB3.80 MiB1.17 MiB
7eff2d7+dirty2.63 MiB3.79 MiB1.16 MiB
11cc947+dirty2.63 MiB3.82 MiB1.19 MiB
10ec2e1+dirty2.63 MiB3.82 MiB1.19 MiB
3c99746+dirty2.63 MiB3.78 MiB1.15 MiB

Previous results on branch: antonis/bump-js10

Startup times

RevisionPlainWith SentryDiff
aeced70+dirty1222.69 ms1222.17 ms-0.53 ms

App size

RevisionPlainWith SentryDiff
aeced70+dirty2.63 MiB3.87 MiB1.24 MiB

@github-actions

github-actionsBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time370.68 ms421.73 ms51.05 ms
Size7.15 MiB8.41 MiB1.26 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
0e27665+dirty355.91 ms422.52 ms66.61 ms
7eff2d7+dirty393.13 ms426.77 ms33.65 ms
f870f2d+dirty398.49 ms434.24 ms35.75 ms
26515b5+dirty389.83 ms443.94 ms54.11 ms
472960b+dirty394.39 ms376.18 ms-18.20 ms
11cc947+dirty385.96 ms420.08 ms34.12 ms
20d0171+dirty380.17 ms422.57 ms42.40 ms
c26618b+dirty354.44 ms414.73 ms60.29 ms
10ec2e1+dirty373.87 ms443.64 ms69.78 ms
3c99746+dirty400.65 ms399.59 ms-1.06 ms

App size

RevisionPlainWith SentryDiff
0e27665+dirty7.15 MiB8.35 MiB1.20 MiB
7eff2d7+dirty7.15 MiB8.35 MiB1.20 MiB
f870f2d+dirty7.15 MiB8.34 MiB1.18 MiB
26515b5+dirty7.15 MiB8.36 MiB1.21 MiB
472960b+dirty7.15 MiB8.34 MiB1.18 MiB
11cc947+dirty7.15 MiB8.36 MiB1.20 MiB
20d0171+dirty7.15 MiB8.35 MiB1.20 MiB
c26618b+dirty7.15 MiB8.36 MiB1.20 MiB
10ec2e1+dirty7.15 MiB8.35 MiB1.20 MiB
3c99746+dirty7.15 MiB8.34 MiB1.18 MiB

Previous results on branch: antonis/bump-js10

Startup times

RevisionPlainWith SentryDiff
aeced70+dirty358.91 ms409.28 ms50.37 ms

App size

RevisionPlainWith SentryDiff
aeced70+dirty7.15 MiB8.41 MiB1.26 MiB

@github-actions

github-actionsBot commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1212.63 ms1214.06 ms1.43 ms
Size3.19 MiB4.44 MiB1.25 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
c26618b+dirty1228.54 ms1236.52 ms7.98 ms
0e27665+dirty1207.12 ms1220.33 ms13.20 ms
20d0171+dirty1214.21 ms1220.31 ms6.10 ms
472960b+dirty1243.67 ms1233.57 ms-10.11 ms
26515b5+dirty1216.98 ms1224.24 ms7.27 ms
fb47c4a+dirty1243.40 ms1245.86 ms2.46 ms
7eff2d7+dirty1224.84 ms1227.94 ms3.10 ms
11cc947+dirty1218.92 ms1234.24 ms15.33 ms
10ec2e1+dirty1229.04 ms1222.28 ms-6.76 ms
3c99746+dirty1227.65 ms1228.81 ms1.16 ms

App size

RevisionPlainWith SentryDiff
c26618b+dirty3.19 MiB4.39 MiB1.20 MiB
0e27665+dirty3.19 MiB4.37 MiB1.18 MiB
20d0171+dirty3.19 MiB4.37 MiB1.18 MiB
472960b+dirty3.19 MiB4.36 MiB1.17 MiB
26515b5+dirty3.19 MiB4.39 MiB1.20 MiB
fb47c4a+dirty3.19 MiB4.37 MiB1.18 MiB
7eff2d7+dirty3.19 MiB4.36 MiB1.17 MiB
11cc947+dirty3.19 MiB4.39 MiB1.20 MiB
10ec2e1+dirty3.19 MiB4.39 MiB1.20 MiB
3c99746+dirty3.19 MiB4.35 MiB1.16 MiB

Previous results on branch: antonis/bump-js10

Startup times

RevisionPlainWith SentryDiff
aeced70+dirty1239.41 ms1238.65 ms-0.76 ms

App size

RevisionPlainWith SentryDiff
aeced70+dirty3.19 MiB4.44 MiB1.25 MiB

@antonisantonis mentioned this pull request Aug 28, 2025
Closed
Base automatically changed from antonis/bump_to_android_sdk_8.20.0 to v7August 28, 2025 10:14
antonis
antonis commented Aug 28, 2025
View reviewed changes
Comment threaddev-packages/type-check/ts3.8-test/tsconfig.build.json
],
"compilerOptions": {
"skipLibCheck": false,
"skipLibCheck": true,

@antonisantonisAug 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to handle the following type check errors

+ yarn type-check
node_modules/@sentry/browser/build/npm/types-ts3.8/integrations/webWorker.d.ts:4:25 - error TS2304: Cannot find name 'Worker'.
4 addWorker: (worker: Worker) => void;
~~~~~~
node_modules/@sentry/core/build/types-ts3.8/utils/debug-logger.d.ts:18:47 - error TS2339: Property 'assert' does not exist on type 'Console'.
18 assert(...args: Parameters<typeof console.assert>): void;
~~~~~~
node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:276:42 - error TS2304: Cannot find name 'AsyncIterable'.
276 export interface OpenAIStream<T> extends AsyncIterable<T> {
~~~~~~~~~~~~~
node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:277:13 - error TS2339: Property 'asyncIterator' does not exist on type 'SymbolConstructor'.
277 [Symbol.asyncIterator](): AsyncIterator<T>;
~~~~~~~~~~~~~
node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:277:31 - error TS2583: Cannot find name 'AsyncIterator'. Do you need to change your target library? Try changing the `lib` compiler option to es2015 or later.
277 [Symbol.asyncIterator](): AsyncIterator<T>;
~~~~~~~~~~~~~
Found 5 errors.

Any ideas on how to avoid this are more than welcome 🙏

@antonisantonisAug 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that changing "lib": ["es2020"] (from es2015) fixes 3 of the errors.

node_modules/@sentry/browser/build/npm/types-ts3.8/integrations/webWorker.d.ts:4:25 - error TS2304: Cannot find name 'Worker'.
4 addWorker: (worker: Worker) => void;
~~~~~~
node_modules/@sentry/core/build/types-ts3.8/utils/debug-logger.d.ts:18:47 - error TS2339: Property 'assert' does not exist on type 'Console'.
18 assert(...args: Parameters<typeof console.assert>): void;
~~~~~~
Found 2 errors.

@antonis
antonis requested a review from alwxAugust 28, 2025 11:00
@antonisantonis mentioned this pull request Aug 28, 2025
Closed
@antonis

antonis commented Aug 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Currently blocked due to the test failures all of which seem to start with the 9.38.0 (changes) bump.

lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
Comment threadpackages/core/package.json
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
Comment threadpackages/core/package.json Outdated
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
Comment threadsamples/react-native/package.json Outdated
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
Comment threadsamples/react-native-macos/package.json Outdated
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/FeedbackWidget.tsx Outdated
@antonis@lucas-zimerman
Apply suggestions from code review
1e2c7ce
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@antonis

antonis commented Aug 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Currently blocked due to the test failures all of which seem to start with the 9.38.0 (changes) bump.

It seems that the optimisation in getsentry/sentry-javascript#16890 was breaking jest fake timers. Fixed with c9098d7

@antonis
antonis marked this pull request as ready for review August 28, 2025 18:54
lucas-zimerman
lucas-zimerman approved these changes Aug 28, 2025
View reviewed changes

@lucas-zimermanlucas-zimerman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! LGTM!

@antonis
antonis merged commit 3b2e69a into v7Aug 28, 2025
118 of 122 checks passed
@antonis
antonis deleted the antonis/bump-js10 branch August 28, 2025 19:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@alwxalwxAwaiting requested review from alwx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman