Uh oh!
There was an error while loading. Please reload this page.
fix(ci): Handle @sentry-internal/* package renames in JS updater - #6295
Merged
Conversation
The previous fix updated the package names in the updater list but the workspace package.json still references the old @sentry-internal/* names, so yarn up can't find them. This adds a renames mechanism that rewrites package.json entries before running yarn up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename the dependencies directly instead of adding rename logic to the updater script. The packages were renamed upstream in sentry-javascript 10.58.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
….json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
….tools.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit 814a4fb.
antonis
marked this pull request as ready for review
June 16, 2026 07:55
Uh oh!
There was an error while loading. Please reload this page.
alwx
approved these changes
Jun 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The previous fix updated the package names in the updater's packages list, but
packages/core/package.jsonstill references the old@sentry-internal/*names. Whenyarn upruns with the new@sentry/*names, it fails because those patterns don't match any packages in the workspace.The rename was introduced upstream in getsentry/sentry-javascript#21371.
💡 Motivation and Context
The JS updater workflow continues to fail on main with:
💚 How did you test it?
Triggered the check on the current branch with 814a4fb
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps