chore(SDK's): Update various SDK versions/urls - #13225

Merged
lobsterkatie merged 3 commits into
masterfrom
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged

chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom
kmclb-update-sdk-versions-may-2019

Conversation

@lobsterkatie

@lobsterkatielobsterkatie commented May 15, 2019•
edited
Loading

Copy link
Copy Markdown
Member

... so that the UI will correctly report when the SDK used to capture an event is out of date.

NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)

@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?

[UPDATE: There are a few others missing, too. Worth adding them?]

@lobsterkatie
lobsterkatie requested a review from HazATMay 15, 2019 19:51
@HazAT

HazAT commented May 20, 2019

Copy link
Copy Markdown
Member

@lobsterkatie Would be awesome if you could add it.
Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.
Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485

Wouldn't be that hard to do, let me know what you think.

@lobsterkatie

lobsterkatie commented May 21, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.

We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.

There are two options:

  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.

  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.

Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.

So, leaning towards 1), but would love your take on it.

*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.

**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.

@HazAT

HazAT commented May 23, 2019

Copy link
Copy Markdown
Member

@lobsterkatie Good catch!
We will fix the rust identifier.

I would merge this for now and go with the pragmatic approach.
We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.

@lobsterkatielobsterkatie changed the title chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie merged commit 93128ef into masterMay 29, 2019
@lobsterkatie
lobsterkatie deleted the kmclb-update-sdk-versions-may-2019 branch May 29, 2019 18:25
@HazAT

HazAT commented May 29, 2019

Copy link
Copy Markdown
Member

🎉

jan-auer added a commit that referenced this pull request May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HazATHazATHazAT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(SDK's): Update various SDK versions/urls - #13225
Merged
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged
chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits into
masterfrom 
kmclb-update-sdk-versions-may-2019
Conversation
@lobsterkatie
@lobsterkatielobsterkatie
commented
May 15, 2019•

edited

Loading

Copy link


Copy Markdown

Member
... so that the UI will correctly report when the SDK used to capture an event is out of date.
NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)
@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?
[UPDATE: There are a few others missing, too. Worth adding them?]
@lobsterkatie
lobsterkatie
requested a review
from HazATMay 15, 2019 19:51
@HazAT
HazAT
commented
May 20, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Would be awesome if you could add it.

Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.

Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485
Wouldn't be that hard to do, let me know what you think.
@lobsterkatie
lobsterkatie
commented
May 21, 2019•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.
We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.
There are two options:
  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.
  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.
Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.
So, leaning towards 1), but would love your take on it.
*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.
**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.
@HazAT
HazAT
commented
May 23, 2019

Copy link


Copy Markdown

Member
@lobsterkatie Good catch!

We will fix the rust identifier.
I would merge this for now and go with the pragmatic approach.

We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.
@lobsterkatielobsterkatie
changed the title
chore(SDK's): Update php/laravel versions/urlschore(SDK's): Update various SDK versions/urlsMay 29, 2019
@lobsterkatie
lobsterkatie
merged commit 93128ef
into
masterMay 29, 2019
@lobsterkatie
lobsterkatie
deleted the

kmclb-update-sdk-versions-may-2019

branch
May 29, 2019 18:25
@HazAT
HazAT
commented
May 29, 2019

Copy link


Copy Markdown

Member
🎉
jan-auer added a commit
that referenced
this pull request
May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2
* master: (30 commits)
ref(ui): Avoid full-page load indicator after project creation (#12842)
ref(events-v2) Use an object target instead building URLs (#13471)
ref(onboarding): Improve alerts from wizard docs (#13469)
feat(app-platform): integration feature models, serializer, endpoints (#13377)
ref(onboarding): Improve platform picker hover color (#13468)
chore: New SDK versions (#13465)
feat(events-v2) Add rough sketch of event modal (#13415)
chore(south) Update south state to use new jsonfield (#13466)
fix(events-v2): Fix search filter (#13454)
chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
test(events-v2): Fix dynamic values in Percy (#13463)
dx(notion): Upgrade from `notion` to `volta` (#13452)
feat(onboarding): Add warning for when docs are missing examples (#13445)
misc(metrics): First pass at un-sampled single metric paths. (#13434)
fix(integrations) Fix missing identity link on re-install (#13450)
fix(api): Fix bug when creating incident comments while logged in as another user.
fix(api): Fix task error on incident creation
chore(SDK's): Update various SDK versions/urls (#13225)
chore: Make exports and imports match (#13449)
feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
...
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@HazATHazATHazAT approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie@HazAT