Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
[WIP] Adding more detail to PullRequestCheckView - #2013
Open
StanleyGoldman wants to merge 38 commits into
Open
Conversation
donokuda
commented
Oct 25, 2018
Contributor
@StanleyGoldman I pushed a couple of commits cleaning this up. This should be ready for review now but I'm happy to incorporate design changes that people might have: |
Codecov Report
@@ Coverage Diff @@## master #2013 +/- ##
=========================================
Coverage ? 39.34% =========================================
Files ? 411 Lines ? 17619 Branches ? 2440 =========================================
Hits ? 6933 Misses ? 10125 Partials ? 561
|
StanleyGoldman
commented
Oct 30, 2018
ContributorAuthor
It's looking good. I tweaked it so the "Finished - 4s" part appears as a tooltip instead. |
StanleyGoldman
commented
Oct 30, 2018
ContributorAuthor
# Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCheckViewModel.cs # src/GitHub.Exports/Models/CheckRunModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs # src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
Adding indications for protected branches
donokuda
commented
Dec 14, 2018
Contributor
I went ahead and polished this up a bit: I forced the required badge to show in order to test my styles and reverted that change in 6691ab7 |
# Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs # src/GitHub.Resources/Resources.zh-CN.resx # src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml # src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml # src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml
StanleyGoldman
commented
Feb 27, 2019
ContributorAuthor
donokuda
commented
Feb 27, 2019
Contributor
I'm taking a look at this right now and will push a fix 👀 |
donokuda
commented
Feb 27, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










Fixes#1967
DataGridinstead of a list control