Uh oh!
There was an error while loading. Please reload this page.
Rust: More conservative resolution of <Foo as Bar<...>> paths - #21420
Merged
hvitved merged 2 commits intoMar 6, 2026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
hvitvedforce-pushed
the
rust/type-inference-qualified-trait-arg-path
branch
from
March 5, 2026 20:42
d83ebf0 to
ff41917Comparehvitved
marked this pull request as ready for review
March 6, 2026 05:10
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to #21188 that tightens resolution for Rust <Foo as Bar<...>> associated-type paths to address a performance regression observed on mycroft/challenges.
Changes:
- Refines associated-type path handling in the Rust type-inference libraries to be more conservative when resolving
<Type as Trait<...>>::Assoc. - Adds a new regression test (
regression2) exercisingSubimpl selection and associated-type projection through<S1 as Sub<S2>>::Output. - Updates type-inference test expectations to reflect the new (more conservative) resolution behavior and removes a previous consistency expectation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/internal/typeinference/TypeMention.qll | Adjusts internal type-mention logic for concrete-type associated-type resolution. |
| rust/ql/lib/codeql/rust/internal/typeinference/AssociatedType.qll | Refines identification/resolution of <type as trait>::name paths. |
| rust/ql/test/library-tests/type-inference/regressions.rs | Adds a new regression covering <S1 as Sub<S2>>::Output and dispatch behavior. |
| rust/ql/test/library-tests/type-inference/associated_types.rs | Updates inline expectations for a generic-trait associated-type test to reflect conservative resolution. |
| rust/ql/test/library-tests/type-inference/type-inference.expected | Updates generated expected results for type inference tests. |
| rust/ql/test/library-tests/type-inference/CONSISTENCY/TypeInferenceConsistency.expected | Updates generated consistency expectations (removes a previously-recorded case). |
paldepind
approved these changes
Mar 6, 2026
paldepind
left a comment
Contributor
There was a problem hiding this comment.
Makes sense given that this fixes timeouts. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21188 follow-up. Fixes a performance regression seen on the project
mycroft/challenges.