Uh oh!
There was an error while loading. Please reload this page.
chore: use node16 for actions - #24540
Merged
Merged
Conversation
There are some yaml and markdown file actions that still using `node12`, update these actions to `node16`.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
cmwilson21
commented
Mar 20, 2023
Contributor
@WaterLemons2k Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
mchammer01
self-requested a review
March 21, 2023 15:45
mchammer01
commented
Mar 21, 2023
Contributor
@WaterLemons2k - thanks for improving our docs ✨ I have asked the relevant team to check that these changes are correct, and I am wondering if we should use a variable for all these instances. |
Member
VerificationUsing a little bit of bash scripting and the handy gh cli: #!/bin/bashset -e
CHANGED_ACTIONS="$(git --no-pager diff main...HEAD --diff-filter=M | grep -oE '^[+]\s*[-]*\s*uses:\s*?([A-Za-z\-]*)/([A-Za-z0-9\-]*)@([0-9a-z.]*)'| grep -oE '([A-Za-z\-]*)/([A-Za-z0-9\-]*)@([0-9a-z.]*)')"# Create a markdown tableecho"| Verified | Action | Version | SHA | Commit Message | URL | Actions YAML |"echo"| -------- | ------ | ------- | --- | -------------- | --- | ------------ |"# Loop over the changed actionsforACTIONin$CHANGED_ACTIONS;do# Get the action name and version
ACTION_NAME="$(echo $ACTION| cut -d'@' -f1)"
ACTION_VERSION="$(echo $ACTION| cut -d'@' -f2)"# Get the SHA, commit message (first line only!) and URL for the action version
ACTION_METADATA=$(gh api -X GET "repos/$ACTION_NAME/commits/$ACTION_VERSION"| jq -r '.sha + " | " + (.commit.message | split("\n")[0]) + " | " + .html_url')
ACTIONS_YAML="https://raw.githubusercontent.com/$ACTION_NAME/$ACTION_VERSION/action.yml"
RUNS_USING="$(curl -s $ACTIONS_YAML| yq '.runs.using')"
VERIFIED=""if [ "$RUNS_USING"=="node16" ];then
VERIFIED="✅"fiecho"| $VERIFIED | $ACTION_NAME | $ACTION_VERSION | $ACTION_METADATA | $ACTIONS_YAML |"doneWe get this:
Edit: I updated the script to check and parse the value of the |
WaterLemons2k
commented
Mar 29, 2023
ContributorAuthor
These commits didn't show the runtime change from node12 to node16 because some actions already have commits using node16 being used (e.g. |
Member
Yep thank you @WaterLemons2k 🙏 my comment was for my team so that we make sure to do another manual verification for those. Also, since we're updating the versions, we might as well upgrade to the latest. |
mchammer01
removed their request for review
March 31, 2023 12:23
ethanpalm
approved these changes
Apr 19, 2023
ethanpalm
left a comment
Contributor
There was a problem hiding this comment.
👍🏼 from @github/docs-content-strategy for the changes in contributing/
Member
April 20th
|
Link-
approved these changes
Apr 20, 2023
myarb
enabled auto-merge
April 20, 2023 12:52
myarb
disabled auto-merge
April 20, 2023 13:09
Contributor
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
There're some actions that still using
node12, update these actions tonode16.Closes#24539
What's being changed (if available, include any code snippets, screenshots, or gifs):
Any actions changed in this PR will use
node16.Check off the following: