Skip to content

Change SSH key generation instructions to use the Ed25519 algorithm - #940

Merged
hubwriter merged 4 commits into
github:mainfrom
keremgocen:876/ssh-key-generation-instructions-Ed25519
Nov 6, 2020
Merged

Change SSH key generation instructions to use the Ed25519 algorithm#940
hubwriter merged 4 commits into
github:mainfrom
keremgocen:876/ssh-key-generation-instructions-Ed25519

Conversation

@keremgocen

@keremgocenkeremgocen commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

Why:

Complements the work done for #362 by editing the related pages to change SSH key generation instructions to use the Ed25519 algorithm.

What's being changed:

The following pages are updated with Ed25519 changes suggested in #876

Check off the following:

@welcome

welcomeBot commented Oct 30, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@keremgocenkeremgocen changed the title 876/ssh key generation instructions ed25519Change SSH key generation instructions to use the Ed25519 algorithmOct 30, 2020
@keremgocen

keremgocen commented Oct 30, 2020

Copy link
Copy Markdown
ContributorAuthor

Actually some local tests are failing but I don't think they are related, same tests are failing on the main branch as well.
My node version is v12.18.3

 FAIL tests/rendering/server.js (29.706 s)
● static assets › fonts
expect(received).toBe(expected) // Object.is equality
Expected: 200
Received: 404
565 | describe('static assets', () => {
566 | test('fonts', async () => {
> 567 | expect((await get('/dist/fonts/Inter-Medium.woff')).statusCode).toBe(200)
| ^
568 | expect((await get('/dist/fonts/Inter-Regular.woff')).statusCode).toBe(200)
569 | })
570 | })
at Object.<anonymous> (tests/rendering/server.js:567:69)
at runMicrotasks (<anonymous>)
● stylesheets › compiles and sets the right content-type header
expect(received).toBe(expected) // Object.is equality
Expected: 200
Received: 404
663 | it('compiles and sets the right content-type header', async () => {
664 | const res = await get('/dist/index.css')
> 665 | expect(res.statusCode).toBe(200)
| ^
666 | expect(res.headers['content-type']).toBe('text/css; charset=UTF-8')
667 | })
668 | })
at Object.<anonymous> (tests/rendering/server.js:665:28)
at runMicrotasks (<anonymous>)
● client-side JavaScript bundle › returns a 200 response
expect(received).toBe(expected) // Object.is equality
Expected: 200
Received: 404
676 |
677 | it('returns a 200 response', async () => {
> 678 | expect(res.statusCode).toBe(200)
| ^
679 | })
680 |
681 | it('sets the right content-type header', async () => {
at Object.<anonymous> (tests/rendering/server.js:678:28)
at runMicrotasks (<anonymous>)
● client-side JavaScript bundle › sets the right content-type header
expect(received).toBe(expected) // Object.is equality
Expected: "application/javascript; charset=UTF-8"
Received: "text/html; charset=utf-8"
680 |
681 | it('sets the right content-type header', async () => {
> 682 | expect(res.headers['content-type']).toBe('application/javascript; charset=UTF-8') | ^
683 | })
684 |
685 | // TODO: configure webpack to create production bundle in the test env
at Object.<anonymous> (tests/rendering/server.js:682:41)
at runMicrotasks (<anonymous>)
FAIL tests/javascripts/user-agent.js
● Test suite failed to run
Jest encountered an unexpected token
This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.
By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

@hubwriterhubwriter self-assigned this Nov 2, 2020
@sarahssarahs mentioned this pull request Nov 2, 2020
@sarahs

Copy link
Copy Markdown
Contributor

👋 @keremgocen I think running npm run build locally should fix those errors. This is a one-time step to create static assets.

I thought we had internal documentation about this but couldn't find it, so I opened #984 to add this info.

@hubwriterhubwriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keremgocen - The changes you've made all look good. 👍
Many thanks for contributing. 🎖️

@hubwriter
hubwriter merged commit 30bc62e into github:mainNov 6, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@keremgocen
keremgocen deleted the 876/ssh-key-generation-instructions-Ed25519 branch November 7, 2020 11:46
@Link-Link- mentioned this pull request Mar 29, 2023
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@keremgocen@sarahs@hubwriter