Skip to content

correct for windows slashes in redirect precompile - #312

Closed
jeffmcaffer wants to merge 3 commits into
mainfrom
jeffmcaffer-patch-2
Closed

correct for windows slashes in redirect precompile#312
jeffmcaffer wants to merge 3 commits into
mainfrom
jeffmcaffer-patch-2

Conversation

@jeffmcaffer

@jeffmcafferjeffmcaffer commented Oct 9, 2020

Copy link
Copy Markdown

Why:

resolves: #311

What's being changed:

see issue

Check off the following:

@jeffmcaffer
jeffmcaffer requested a review from a team as a code ownerOctober 9, 2020 02:21
@janiceilenejaniceilene added engineering Will involve Docs Engineering windows labels Oct 9, 2020
heiskr
heiskr approved these changes Oct 9, 2020
View reviewed changes

@heiskrheiskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedochiedo mentioned this pull request Oct 9, 2020
Merged
4 tasks
wacek667
wacek667 reviewed Nov 7, 2020
View reviewed changes
Comment threadlib/redirects/precompile.js
@@ -1,4 +1,5 @@
const path = require('path')

This comment was marked as spam.

Sign in to view

Comment threadlib/redirects/precompile.js
@@ -1,4 +1,5 @@
const path = require('path')
const slash = require('slash')

This comment was marked as spam.

Sign in to view

@githubgithub locked as spam and limited conversation to collaborators Nov 9, 2020
@chiedo
chiedo deleted the jeffmcaffer-patch-2 branch November 30, 2020 15:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@heiskrheiskrheiskr approved these changes
@chiedochiedoAwaiting requested review from chiedo
+1 more reviewer
@wacek667wacek667wacek667 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engineeringWill involve Docs Engineering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

developer route redirects load incorrectly on Windows

6 participants

@jeffmcaffer@heiskr@wacek667@janiceilene@Octomerger@zeke