Uh oh!
There was an error while loading. Please reload this page.
Bulk Windows fixes - #369
Merged
Merged
Conversation
…indows-fixes-1602277955
…indows-fixes-1602277955
…indows-fixes-1602277955
…thub/docs into bulk-windows-fixes-1602277955
chiedo
commented
Oct 9, 2020
ContributorAuthor
Tested it here on Windows by manually running the workflow: https://github.com/github/docs/runs/1233548947?check_suite_focus=true. The only test that failed was a non-windows specific test on lint-ing so this is good to go! |
JamesMGreene
approved these changes
Oct 9, 2020
JamesMGreene
left a comment
Member
There was a problem hiding this comment.
Looks good. ✨
Thank you @jeffmcaffer and @chiedo! 💝
Contributor
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Shipping numerous work by @jeffmcaffer in bulk to avoid waiting for multiple checks.
This also enables windows tests on github/docs so we can run windows tests against branches here manually.
Closes#351
Closes#348
Closes#319
Closes#312
Closes: #137
Check off the following: