Skip to content

fix up redirect paths for Windows - #348

Closed
jeffmcaffer wants to merge 1 commit into
mainfrom
jeffmcaffer-patch-4
Closed

fix up redirect paths for Windows#348
jeffmcaffer wants to merge 1 commit into
mainfrom
jeffmcaffer-patch-4

Conversation

@jeffmcaffer

@jeffmcafferjeffmcaffer commented Oct 9, 2020

Copy link
Copy Markdown

Why:

resolves: #313

What's being changed:

wrap path.join with slash() calls

Check off the following:

@jeffmcafferjeffmcaffer added bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering labels Oct 9, 2020
@jeffmcaffer
jeffmcaffer requested a review from a team as a code ownerOctober 9, 2020 15:25
heiskr
heiskr approved these changes Oct 9, 2020
View reviewed changes

@heiskrheiskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedochiedo mentioned this pull request Oct 9, 2020
Merged
4 tasks
@chiedo
chiedo deleted the jeffmcaffer-patch-4 branch November 30, 2020 15:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heiskrheiskrheiskr approved these changes
@chiedochiedoAwaiting requested review from chiedo

Assignees

No one assigned

Labels

bugAn error or flaw that causes unintended or unexpected resultsengineeringWill involve Docs Engineering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

redirects incorrectly computed on Windows

4 participants

@jeffmcaffer@heiskr@janiceilene@Octomerger