Skip to content

handle windows paths in product definitions - #351

Closed
jeffmcaffer wants to merge 2 commits into
mainfrom
jeffmcaffer-patch-5
Closed

handle windows paths in product definitions#351
jeffmcaffer wants to merge 2 commits into
mainfrom
jeffmcaffer-patch-5

Conversation

@jeffmcaffer

@jeffmcafferjeffmcaffer commented Oct 9, 2020

Copy link
Copy Markdown

Why:

resolves#316

What's being changed:

product URLs are being computed based on file system paths so need to be slashed for Windows

Check off the following:

@jeffmcafferjeffmcaffer added bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering labels Oct 9, 2020
@jeffmcaffer
jeffmcaffer requested a review from a team as a code ownerOctober 9, 2020 15:54
heiskr
heiskr approved these changes Oct 9, 2020
View reviewed changes

@heiskrheiskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedochiedo mentioned this pull request Oct 9, 2020
Merged
4 tasks
@nschonninschonni mentioned this pull request Nov 30, 2020
Closed
@githubgithub locked as spam and limited conversation to collaborators Feb 1, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@heiskrheiskrheiskr approved these changes
@chiedochiedoAwaiting requested review from chiedo

Assignees

No one assigned

Labels

bugAn error or flaw that causes unintended or unexpected resultsengineeringWill involve Docs Engineering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

homepage calculation gives bad URLs on Windows

5 participants

@jeffmcaffer@heiskr@chiedo@janiceilene@Octomerger