Uh oh!
There was an error while loading. Please reload this page.
[q] fix(difc): use <b> for bold in details/summary and show #unknown entries with tool name (#22264) - #22291
Merged
Merged
Conversation
- Replace **markdown bold** with <b>HTML bold</b> in the details/summary element since GitHub doesn't render markdown inside summary tags - Filter out events whose resolved reference is #unknown — these are unresolvable GitHub entities and are not valid entries to surface - If all events are #unknown the section is suppressed entirely Fixes#22264 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
commented
Mar 22, 2026
Collaborator
@copilot show the unknown entries, but hide the "#unknown" text |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b6d8ce61-4d24-4bc2-bb54-8d24ac9f9c21
Contributor
CopilotAI
changed the title
[q] fix(difc): use [q] fix(difc): use Mar 22, 2026
<b> for bold in details/summary and hide #unknown entries (#22264)<b> for bold in details/summary and show #unknown entries with tool name (#22264)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the integrity filter blocked message generated by
gateway_difc_filtered.cjs.Changes
1. Use
<b>HTML element for bold in<details><summary>GitHub does not render
**markdown bold**inside<summary>tags. Changed to<b>HTML bold</b>:Before:
After:
2. Show
#unknownentries but hide the#unknowntextEvents whose resolved reference is
#unknown(e.g.description: "github:#unknown") are unresolvable GitHub entities. These entries are now shown in the blocked list, but the#unknowntext is hidden — the entry'stool_nameis used as the reference label instead (falling back to-if absent). The count in the summary includes these entries.Tests
All 30 existing tests pass. Updated 2 tests to reflect the new behavior:
should show events with #unknown description using tool_name insteadshould show entry using tool_name when description is #unknownTriggered by: @pelikhan on #22264
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.