[code-simplifier] refactor: simplify conditional server rows and redundant pattern splitting

[github-actions]

This PR simplifies recently modified code to improve clarity and reduce redundancy while preserving all functionality.

Files Simplified

• pkg/cli/gateway_logs.go — Eliminated duplicated if/else blocks in renderGatewayMetricsTable
• actions/setup/js/push_repo_memory.cjs — Removed redundant fileGlobFilter re-splitting

Improvements Made

pkg/cli/gateway_logs.go — Server rows and table headers deduplication

The renderGatewayMetricsTable function contained two nearly-identical if hasFiltered branches — one to build server rows and one to configure table headers — resulting in ~20 lines of duplicated code. Simplified to build the base row once and conditionally append the Filtered column:

// Before: two separate if/else blocks (each repeating 5 identical fields)ifhasFiltered {
serverRows=append(serverRows, []string{..., strconv.Itoa(server.FilteredCount)})
} else {
serverRows=append(serverRows, []string{...})
}
// ... then another if/else for table config headers// After: build once, append conditionallyrow:= []string{serverName, ...errors}
ifhasFiltered {
row=append(row, strconv.Itoa(server.FilteredCount))
}
serverRows=append(serverRows, row)
headers:= []string{"Server", ..., "Errors"}
ifhasFiltered {
headers=append(headers, "Filtered")
}
output.WriteString(console.RenderTable(console.TableConfig{...}))

actions/setup/js/push_repo_memory.cjs — Pre-compute pattern strings

The scanDirectory function called fileGlobFilter.trim().split(/\s+/).filter(Boolean) three times:

1. To build the regex patterns array
2. Inside the map callback to get each pattern string for debug logging
3. Again in the error block for info logging

Refactored to compute patternStrs once before building patterns, eliminating the redundant re-splits:

// Beforeconstpatterns=fileGlobFilter.trim().split(/\s+/).filter(Boolean).map(...)// inside map:constpatternStr=fileGlobFilter.trim().split(/\s+/).filter(Boolean)[idx]// redundant// in error block:constpatternStrs=fileGlobFilter.trim().split(/\s+/).filter(Boolean)// redundant// AfterconstpatternStrs=fileGlobFilter.trim().split(/\s+/).filter(Boolean);constpatterns=patternStrs.map(pattern=>globPatternToRegex(pattern));// patternStrs is now reused in both map callback and error block

Changes Based On

Recent changes from merged PRs (2026-03-22):

• [q] fix(difc): use <b> for bold in details/summary and show #unknown entries with tool name (#22264) #22291 — fix(difc): use bold in details/summary and show #unknown entries with tool name
• feat(integrity-analysis): add per-user analysis of filtered events #22298 — feat(integrity-analysis): add per-user analysis of filtered events
• fix: exclude .git directory from push_repo_memory size check #22285 — fix: exclude .git directory from push_repo_memory size check

Testing

• ✅ All unit tests pass (go test -count=1 -tags '!integration' ./pkg/cli/)
• ✅ Go formatting passes (gofmt)
• ✅ Build succeeds (go build ./...)
• ✅ No functional changes — behavior is identical

Review Focus

Please verify:

• Server row building produces identical output regardless of hasFiltered
• Pattern matching in push_repo_memory behaves identically (same strings, same regexes)

---

Automated by Code Simplifier Agent — analyzing code from 2026-03-22

Note

🔒 Integrity filter blocked 3 items

The following items were blocked because they don't meet the GitHub integrity level.

• #22296search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• feat(integrity-analysis): add per-user analysis of filtered events #22298pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Add per-handler staged mode to all safe output types #22284pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
github:
min-integrity: approved # merged | approved | unapproved | none

Generated by Code Simplifier · ◷

• expires on Mar 23, 2026, 7:07 PM UTC

[Copilot]

Pull request overview

This PR refactors two recently modified areas to reduce duplication and improve clarity without changing behavior.

Changes:

• Simplifies renderGatewayMetricsTable by building a single server row/header set and conditionally appending the Filtered column.
• Avoids redundant FILE_GLOB_FILTER splitting in push_repo_memory.cjs by computing patternStrs once per scan.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/cli/gateway_logs.go	Deduplicates server-row and header construction in the gateway metrics table, conditionally adding the Filtered column.
actions/setup/js/push_repo_memory.cjs	Precomputes glob pattern strings once to avoid repeated trim/split/filter work during pattern validation/logging.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The refactor changes how the “Filtered” column and headers are constructed when metrics.TotalFiltered > 0, but there doesn’t appear to be a unit test that asserts the rendered table includes the Filtered header and the per-server filtered counts. Adding a test case with TotalFiltered > 0 (and a server with FilteredCount) would help prevent regressions in column alignment/output formatting.