Skip to content

Fix some resource leaks by open file handles - #1532

Merged
Byron merged 1 commit into
gitpython-developers:mainfrom
marlamb:feature/reduce-resource-leaks
Jan 9, 2023
Merged

Fix some resource leaks by open file handles#1532
Byron merged 1 commit into
gitpython-developers:mainfrom
marlamb:feature/reduce-resource-leaks

Conversation

@marlamb

Copy link
Copy Markdown

No description provided.

@marlamb
marlambforce-pushed the feature/reduce-resource-leaks branch from 752dd1a to d3dbe6cCompareJanuary 8, 2023 23:05
@marlamb
marlambforce-pushed the feature/reduce-resource-leaks branch from d3dbe6c to e500466CompareJanuary 8, 2023 23:10
@ByronByron added this to the v3.1.31 - Bugfixes milestone Jan 9, 2023
@Byron

Byron commented Jan 9, 2023

Copy link
Copy Markdown
Member

Thanks a lot, amazing fixes!
It's odd that these survived so long, maybe this indicates the GitPython is mostly used in one-off commands rather than long running processes.

@Byron
Byron merged commit 90c81a5 into gitpython-developers:mainJan 9, 2023
@marlamb

Copy link
Copy Markdown
Author

You are welcome, thanks for merging that quickly!

@Codym48

Copy link
Copy Markdown
Contributor

Thank you for committing this @marlamb and merging it @Byron!

(We only tripped over one of these after we enabled filterwarnings("error") and executed the pytest suite locally within a linked worktree. It didn't appear when running within the main worktree or within any CI pipeline.)

Any idea when the next release is scheduled? Can I volunteer to help?

@Byron

Copy link
Copy Markdown
Member

@Codym48 Thanks for your help! It would be great if #1535 cold be merged before a release is created, it's just missing a test. You could probably submit a PR on top of that one to add it. Thank you.

@Codym48

Copy link
Copy Markdown
Contributor

How about something like this? kfreezen#1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@marlamb@Byron@Codym48