Uh oh!
There was an error while loading. Please reload this page.
Proposed change to get_values behavior - #1535
Conversation
kfreezen
commented
Jan 10, 2023
Proposed fix for #1534 |
kfreezen
commented
Jan 10, 2023
Looking at test here; I suppose we can leave it raising a KeyError. The main fix was force-loading the I'll re-commit using KeyError. |
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated!
I think the commit should link back to the issue it resolve to create a more declarative history.
Finally it should be possible to devise a test that would fail without this change to cement it. Otherwise it might be removed in future because it's unclear why eager loading of sections is necessary.
Codym48
commented
Feb 16, 2023
@kfreezen, consider accepting kfreezen#1 to add test coverage for this change? I verified it fails on main: |
Byron
commented
Feb 16, 2023
Closing as it's superseded by #1555 |

get_values() did not load existing sections before checking the
_sectionsproperty.NOTE: Haven't written a test to check for this yet.