Skip to content

read workdir from git.config as referenced in man 1 git-config - #801

Closed
Farom wants to merge 1 commit into
gitpython-developers:masterfrom
Farom:worktree_from_config
Closed

read workdir from git.config as referenced in man 1 git-config#801
Farom wants to merge 1 commit into
gitpython-developers:masterfrom
Farom:worktree_from_config

Conversation

@Farom

Copy link
Copy Markdown
Contributor

The setting in .git/config for GIT_WORK_TREE were ignored.
I tried to implement this as git-config says.

@codecov-io

codecov-io commented Sep 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #801 into master will decrease coverage by 0.46%.
The diff coverage is 83.33%.

Impacted file tree graph

@@ Coverage Diff @@## master #801 +/- ##
==========================================
- Coverage 94.71% 94.25% -0.47% 
==========================================
Files 59 59 Lines 9369 9374 +5 ==========================================
- Hits 8874 8835 -39 - Misses 495 539 +44
Impacted FilesCoverage Δ
git/repo/base.py95.36% <83.33%> (-0.85%)⬇️
git/test/test_util.py90.07% <0%> (-8.52%)⬇️
git/test/test_base.py96.42% <0%> (-2.39%)⬇️
git/objects/submodule/base.py92.89% <0%> (-1.46%)⬇️
git/test/test_submodule.py97.89% <0%> (-1.35%)⬇️
git/test/lib/helper.py90.69% <0%> (-1.17%)⬇️
git/test/test_repo.py97.24% <0%> (-0.65%)⬇️
git/cmd.py83.4% <0%> (-0.44%)⬇️
git/test/test_docs.py99.6% <0%> (-0.4%)⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8591a0...47f45cf. Read the comment docs.

@Farom
Faromforce-pushed the worktree_from_config branch from 7da0303 to 47f45cfCompareSeptember 28, 2018 18:36
Comment threadgit/repo/base.py
@Byron

Copy link
Copy Markdown
Member

Thanks a lot for your contribution! It's much appreciated.
I also added a comment about something puzzling, maybe you can have a look.
Thank you

@Byron

Copy link
Copy Markdown
Member

One change request was made, after which this PR can be merged. See the resolved conversation in git/repo/base.

@Byron

Copy link
Copy Markdown
Member

Thanks a lot for your contribution thus far !
I am closing this PR due to prolonged inactivity. Please feel free to reopen it in case it can proceed.

@ByronByron closed this Sep 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants

@Farom@codecov-io@Byron@ukleinek