Skip to content

read workdir from git.config as referenced in man 1 git-config - #808

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
fscherf:fscherf/farom/worktree_from_config
Dec 22, 2018
Merged

read workdir from git.config as referenced in man 1 git-config#808
Byron merged 1 commit into
gitpython-developers:masterfrom
fscherf:fscherf/farom/worktree_from_config

Conversation

@fscherf

Copy link
Copy Markdown

Hi @Byron,

I am a co-worker of @Farom and we need his PR #801 merged for one of our future projects. He had no time to add the last feedback so i edited his patch.

Edited-by: Florian Scherf <f.scherf@pengutronix.de>
added the remaining feedback in
https://github.com/gitpython-developers/GitPython/pull/801/files
@fscherf
fscherfforce-pushed the fscherf/farom/worktree_from_config branch from 43803ef to 3863e9eCompareNovember 8, 2018 11:29
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #808 into master will increase coverage by 13.56%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@## master #808 +/- ##
==========================================
+ Coverage 80.24% 93.8% +13.56% 
==========================================
Files 59 59 Lines 11067 9386 -1681 ==========================================
- Hits 8881 8805 -76 + Misses 2186 581 -1605
Impacted FilesCoverage Δ
git/repo/base.py94.38% <85.71%> (+17.21%)⬆️
git/compat.py54.32% <0%> (-3.7%)⬇️
git/test/test_fun.py97.84% <0%> (-1.08%)⬇️
git/test/test_base.py96.42% <0%> (+1.02%)⬆️
git/refs/head.py98.9% <0%> (+1.07%)⬆️
git/test/test_config.py98.33% <0%> (+1.61%)⬆️
git/exc.py96.42% <0%> (+1.69%)⬆️
git/repo/fun.py92.02% <0%> (+2.33%)⬆️
git/objects/base.py95.83% <0%> (+3.83%)⬆️
git/index/util.py90.69% <0%> (+4.03%)⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1fe7f...3863e9e. Read the comment docs.

@fscherf

Copy link
Copy Markdown
Author

i know the tests fail, but is this my fault? Both fails seem like ci config problems.

@Byron
Byron merged commit 530ab00 into gitpython-developers:masterDec 22, 2018
@ByronByron added this to the v2.1.12 - Bugfixes milestone Dec 22, 2018
@Byron

Copy link
Copy Markdown
Member

Sorry for the late reply, and thanks a lot for the contribution.

I do hope to get the tests fixed at some point, being in a red state for too long makes me quite fearful of merging more than typo-fixes in future.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@fscherf@codecov-io@Byron@Farom