Uh oh!
There was an error while loading. Please reload this page.
read workdir from git.config as referenced in man 1 git-config - #808
Merged
Byron merged 1 commit intoDec 22, 2018
Merged
Conversation
Edited-by: Florian Scherf <f.scherf@pengutronix.de> added the remaining feedback in https://github.com/gitpython-developers/GitPython/pull/801/files
fscherfforce-pushed
the
fscherf/farom/worktree_from_config
branch
from
November 8, 2018 11:29
43803ef to
3863e9eComparecodecov-io
commented
Nov 8, 2018
Codecov Report
@@ Coverage Diff @@## master #808 +/- ##
==========================================
+ Coverage 80.24% 93.8% +13.56%
==========================================
Files 59 59 Lines 11067 9386 -1681 ==========================================
- Hits 8881 8805 -76 + Misses 2186 581 -1605
Continue to review full report at Codecov.
|
fscherf
commented
Nov 26, 2018
Author
i know the tests fail, but is this my fault? Both fails seem like ci config problems. |
Byron
commented
Dec 22, 2018
Member
Sorry for the late reply, and thanks a lot for the contribution. I do hope to get the tests fixed at some point, being in a red state for too long makes me quite fearful of merging more than typo-fixes in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Byron,
I am a co-worker of @Farom and we need his PR #801 merged for one of our future projects. He had no time to add the last feedback so i edited his patch.