Uh oh!
There was an error while loading. Please reload this page.
refactor: fix ops.StrftimeOp, ops.ToDatetimeOp, ops.ToTimestampOp in sqlglot compiler - #2297
Merged
Conversation
chelsea-linforce-pushed
the
main_chelsealin_todatelike
branch
from
November 26, 2025 00:53
546607a to
c99acc9Comparechelsea-lin
marked this pull request as ready for review
November 26, 2025 00:57
sycai
reviewed
Nov 26, 2025
Comment on lines
+44
to
+45
| if expr.dtype != dtypes.INT_DTYPE: | ||
| value = sge.Cast(this=value, to=sge.DataType(this="INT64")) |
Contributor
There was a problem hiding this comment.
Should we remove this branch? "to_timedelta" only supports int, float and timedelta inputs: https://github.com/googleapis/python-bigquery-dataframes/blob/d1ecc61bf448651a0cca0fc760673da54f5c2183/bigframes/operations/timedelta_ops.py#L28-L35
ContributorAuthor
There was a problem hiding this comment.
Got it. Yeah, the logic are same but I just refactored it for more readable, after having these information. Thanks
sycai
approved these changes
Nov 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to fix the
to_datetimerelated tests failing in #2248.Fixes internal issue 417774347 🦕