Skip to content

feat: enable SQLGlot compiler as default - #2248

Closed
chelsea-lin wants to merge 2 commits into
mainfrom
main_chelsealin_enablesqlglot2
Closed

feat: enable SQLGlot compiler as default#2248
chelsea-lin wants to merge 2 commits into
mainfrom
main_chelsealin_enablesqlglot2

Conversation

@chelsea-lin

@chelsea-linchelsea-lin commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes internal issue 417774347🦕

@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 10, 2025
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 7a011e1 to d634b06CompareNovember 11, 2025 00:22
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. and removed size: l Pull request size is large. labels Nov 11, 2025
@chelsea-linchelsea-lin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2025
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from d634b06 to c90c084CompareNovember 12, 2025 20:59
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from c90c084 to eb8e92cCompareNovember 24, 2025 23:12
@chelsea-linchelsea-lin mentioned this pull request Nov 25, 2025
Merged
chelsea-lin added a commit that referenced this pull request Nov 25, 2025
@chelsea-lin
refactor: switch RowNumber to 0-based indexing in sqlglot compiler (#…
3275761
…2292)
This change aims to fix the tests failing in #2248 because of a 1-based
indexing error.
Fixes internal issue 417774347 🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 689b4e4 to 39096e5CompareNovember 25, 2025 21:49
This was referenced Nov 25, 2025
Merged
Merged
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
@chelsea-lin
refactor: fix ops.StrftimeOp, ops.ToDatetimeOp, ops.ToTimestampOp in …
9e0f70b
…sqlglot compiler (#2297)
This change aims to fix the `to_datetime` related tests failing in
#2248.
Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
@chelsea-lin
refactor: fix agg_ops.DiffOp for Datetime and Timestamp (#2296)
33a211e
This change aims to fix the `test_timestamp_series_diff_agg` test
failing in #2248.
Fixes internal issue 417774347 🦕
@chelsea-linchelsea-lin mentioned this pull request Nov 26, 2025
Merged
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 39096e5 to 2f63b1fCompareNovember 26, 2025 23:28
chelsea-lin added a commit that referenced this pull request Dec 1, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler. (#2299)
aae1b04
This change aims to fix some string-related tests failing in #2248.
Fixes internal issue 417774347🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 2f63b1f to 6d1b653CompareDecember 15, 2025 05:52
@chelsea-linchelsea-lin mentioned this pull request Dec 15, 2025
Merged
chelsea-lin added a commit that referenced this pull request Dec 16, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler (part 2) (#2332)
0b14b17
This change aims to fix some string-related tests failing in #2248.
Fixes internal issue 417774347🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 6d1b653 to 82ac904CompareDecember 16, 2025 02:41
This was referenced Dec 17, 2025
Merged
Merged
shuoweil pushed a commit that referenced this pull request Dec 17, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler (part 3) (#2336)
097fcfa
This change aims to fix some string-related tests failing in #2248.
Fixes internal issue 417774347 🦕
@chelsea-linchelsea-lin mentioned this pull request Dec 18, 2025
Merged
chelsea-lin added a commit that referenced this pull request Dec 19, 2025
@chelsea-lin@sycai
refactor: Handle special float values and None consistently in sqlglo…
7d152d3
…t _literal (#2337)
This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`
Fixes internal issue 417774347🦕
---------
Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin@sycai@shuoweil
refactor: Handle special float values and None consistently in sqlglo…
81d1dbe
…t _literal (#2337)
This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`
Fixes internal issue 417774347🦕
---------
Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
tswast pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin
refactor: fix SQLGlot doctests on the window, ai, to_json ops (#2341)
3c54c68
This change can resolve three doctests failures in #2248: - Added `to_json` support to the compiler backend.
- Fixed minor bugs on AI ops
- Fixed minor bugs on windows compiler
Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Jan 15, 2026
@chelsea-lin
refactor: adds null literal checks when sqlglot compiling eq and nq o…
173efd9
…ps (#2381)
This change adds null literal checks during the compilation of eq, ne
and map ops. This aims to resolve the
`test_series_replace_nans_with_pd_na` failure reported in #2248.
Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Jan 15, 2026
@chelsea-lin
refactor: fix some aggregation ops in the sqlglot compiler (#2382)
e1d54d2
This change fixes several aggregation-related test failures in #2248 by
including the following operators:
- `agg_ops.DiffOp`: Fixes test_date_series_diff_agg
- `agg_ops.AllOp/AnyOp`: Fixes test_list_apply_callable
- `agg_ops.QuantileOp`: Fixes test_dataframe_aggregates_median
- `agg_ops.ProductOp`: Fixes test_dataframe_groupby_analytic
Fixes internal issue 417774347 🦕
@chelsea-linchelsea-lin mentioned this pull request Jan 16, 2026
Merged
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 3972dc7 to f900cdbCompareJanuary 16, 2026 06:46
chelsea-lin added a commit that referenced this pull request Jan 21, 2026
@chelsea-lin
refactor: fix math numeric_ops for test_series_ufuncs (#2386)
d02d32f
This change fixes several numeric_ops test failures in #2248
Fixes internal issue 417774347 🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 6adb0e1 to 3325427CompareJanuary 23, 2026 17:51
@chelsea-linchelsea-lin mentioned this pull request Jan 23, 2026
Merged
chelsea-lin added a commit that referenced this pull request Jan 27, 2026
@chelsea-lin
refactor: fix several small presubmit test failures on the SQLGlot co…
a80ac3f
…mpiler (#2406)
This change fixes several presubmit test failures in #2248
Fixes internal issue 417774347 🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 3325427 to d370151CompareJanuary 27, 2026 22:57
@chelsea-linchelsea-lin mentioned this pull request Jan 29, 2026
Merged
chelsea-lin added a commit that referenced this pull request Jan 29, 2026
@chelsea-lin
refactor: fix test_concat_dataframe by de-deuplicating merged ctes in…
83b83ea
… sqlglot (#2414)
This change fixes the `test_concat_dataframe` failures in #2248
Fixes internal issue 417774347 🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 426b6a3 to c31a9d7CompareFebruary 2, 2026 22:36
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 2, 2026
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 34eb4fb to 5a146b3CompareFebruary 10, 2026 18:58
@chelsea-linchelsea-lin mentioned this pull request Feb 16, 2026
Merged
chelsea-lin added a commit that referenced this pull request Feb 17, 2026
@chelsea-lin
refactor: add table aliases to prevent ambiguity in SQLGlotIR (#2458)
a5a1bc1
This change fixes the`test_read_gbq_w_ambigous_name` failures in #2248
Fixes internal issue 417774347 🦕
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 2db43e5 to 5c0a461CompareFebruary 18, 2026 22:59
@chalmerlowe

chalmerlowe commented Mar 2, 2026

Copy link
Copy Markdown

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!

@chelsea-linchelsea-lin reopened this Mar 5, 2026
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from b7453ea to 67210d9CompareMarch 10, 2026 22:02
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_enablesqlglot2 branch from 67210d9 to e3511d7CompareMarch 16, 2026 17:12
@tswast

tswast commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Closing. Let's move this over to https://github.com/googleapis/google-cloud-python once googleapis/google-cloud-python#16493 merges.

@tswasttswast closed this Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin@chalmerlowe@tswast