Skip to content

refactor: Handle special float values and None consistently in sqlglot _literal - #2337

Merged
chelsea-lin merged 3 commits into
mainfrom
main_chelsealin_literal
Dec 19, 2025
Merged

refactor: Handle special float values and None consistently in sqlglot _literal#2337
chelsea-lin merged 3 commits into
mainfrom
main_chelsealin_literal

Conversation

@chelsea-lin

@chelsea-linchelsea-lin commented Dec 17, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This change can resolve two doctests failures in #2248: groupby.GroupBy.rank and bigframes.ml.metrics.roc_curve

Fixes internal issue 417774347🦕

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 17, 2025
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_literal branch from 85292df to ca3023aCompareDecember 17, 2025 13:34
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 17, 2025
@chelsea-lin
chelsea-lin marked this pull request as ready for review December 17, 2025 13:35
@chelsea-lin
chelsea-lin requested review from a team and jialuooDecember 17, 2025 13:35
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_literal branch from ca3023a to 1b28f4cCompareDecember 18, 2025 02:51
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_literal branch from 1b28f4c to 60d3483CompareDecember 18, 2025 03:04
@chelsea-lin
chelsea-lin merged commit 7d152d3 into mainDec 19, 2025
24 of 25 checks passed
@chelsea-lin
chelsea-lin deleted the main_chelsealin_literal branch December 19, 2025 07:58
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin@sycai@shuoweil
refactor: Handle special float values and None consistently in sqlglo…
81d1dbe
…t _literal (#2337)
This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`
Fixes internal issue 417774347🦕
---------
Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jialuoojialuooAwaiting requested review from jialuoo
1 more reviewer
@sycaisycaisycai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TrevorBergeronTrevorBergeron

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin@sycai@TrevorBergeron