Uh oh!
There was an error while loading. Please reload this page.
Add Support to preview endpoints to list branches or pull requests fo… - #1186
Conversation
a057467 to
cd62ca4CompareCodecov Report
@@ Coverage Diff @@## master #1186 +/- ##
=========================================
- Coverage 70.24% 70.2% -0.04%
=========================================
Files 84 84 Lines 5878 5904 +26 =========================================
+ Hits 4129 4145 +16 - Misses 958 963 +5 - Partials 791 796 +5
Continue to review full report at Codecov.
|
| ListOptions | ||
| } | ||
| // BranchCommit is the result of listing branches with commit sha. |
There was a problem hiding this comment.
Let's please change this to SHA instead of sha.
(Also, please don't use force commits just to make things easier for reviewers.)
| // ListBranchesHeadCommit gets all branches where the given commit SHA is the HEAD, | ||
| // or latest commit for the branch. | ||
| // | ||
| // Github API docs: https://developer.github.com/v3/repos/commits/#list-branches-for-head-commit |
There was a problem hiding this comment.
Please capitalize the H in GitHub.
sks444
commented
Jun 9, 2019
Thanks for the review @gmlewis, I have updated the PR. |
| client, mux, _, teardown := setup() | ||
| defer teardown() | ||
| // given |
There was a problem hiding this comment.
Please don't add incomplete comment, can you please remove it?
| // TODO: remove custom Accept header when this API fully launches. | ||
| acceptHeaders := []string{mediaTypeLabelDescriptionSearchPreview, mediaTypeLockReasonPreview, mediaTypeDraftPreview} | ||
| req.Header.Set("Accept", strings.Join(acceptHeaders, ", ")) | ||
| var pulls []*PullRequest |
There was a problem hiding this comment.
Please don't edit code which is not related to the issue 😄
vaibhavsingh97
left a comment
There was a problem hiding this comment.
LGTM, just a minor change needed.
Good work @sks444 ! 🎉
googlebot
commented
Jun 10, 2019
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
sks444
commented
Jun 10, 2019
Thanks @vaibhavsingh97, I have updated the pr according to your review. @gmlewis, There was some conflicts so I did the rebase and did the push without using |
gmlewis
commented
Jun 10, 2019
@sks444 - sure, go ahead and do a force push since all the review feedback has already been addressed. That should hopefully clear it up. |
1fb3a7b to
bc8872cComparegooglebot
commented
Jun 10, 2019
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
sks444
commented
Jun 10, 2019
Thanks @gmlewis, it's done. |
gmlewis
commented
Jun 10, 2019
Thank you, @sks444! Merging. |
…r a commit
Helps #1151