Skip to content

Update comment on ListPullRequestsWithCommit API - #2228

Merged
gmlewis merged 1 commit into
google:masterfrom
mengmichael1:patch-1
Dec 15, 2021
Merged

Update comment on ListPullRequestsWithCommit API#2228
gmlewis merged 1 commit into
google:masterfrom
mengmichael1:patch-1

Conversation

@mengmichael1

Copy link
Copy Markdown
Contributor
  1. Correct the statement that results include open and closed PRs by default, when it is only open by default, per

    typePullRequestListOptionsstruct {
    // State filters pull requests based on their state. Possible values are:
    // open, closed, all. Default is "open".
    Statestring`url:"state,omitempty"`

  2. Correct the URL for the Github API doc, per ListPullRequestsWithCommit removed from API docs?  #2227

@codecov

codecovBot commented Dec 14, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2228 (854edb5) into master (ff33a55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2228 +/- ##
=======================================
Coverage 97.81% 97.81% =======================================
Files 112 112 Lines 10117 10117 =======================================
Hits 9896 9896 Misses 154 154 Partials 67 67 
Impacted FilesCoverage Δ
github/pulls.go96.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff33a55...854edb5. Read the comment docs.

@mengmichael1

mengmichael1 commented Dec 15, 2021

Copy link
Copy Markdown
ContributorAuthor

PTAL @gmlewis, as you pointed me in the right direction for the API docs :) (also saw you helped out with #1186)

Also -- are you a repo manager or can you introduce me to one?

🔁 Repository managers: You can rescan this PR by pressing the "Re-run" button to the left of this description.

I signed the CLA after putting up this PR, so will need a repo manager to re-run the cla/google check for me

@gmlewis

Copy link
Copy Markdown
Collaborator

Yes, I am the primary maintainer of this repo.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mengmichael1 !
LGTM.
Merging.

@gmlewis
gmlewis merged commit fef3638 into google:masterDec 15, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mengmichael1@gmlewis