Skip to content

Add function to delete a workflow run by ID - #2207

Merged
gmlewis merged 2 commits into
google:masterfrom
x4b1:actions/workflows/runs/delete
Nov 26, 2021
Merged

Add function to delete a workflow run by ID#2207
gmlewis merged 2 commits into
google:masterfrom
x4b1:actions/workflows/runs/delete

Conversation

@x4b1

@x4b1x4b1 commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

This Pull request Adds a new function to delete workflows run from workflow history. The same functionality as this button:
Screenshot 2021-11-22 at 11 43 41

I cannot reference the documentation in the function comment because is missing the endpoint in the docs

@x4b1
x4b1force-pushed the actions/workflows/runs/delete branch from 3deebc4 to 94072a5CompareNovember 22, 2021 10:47
@google-clagoogle-claBot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Nov 22, 2021
@codecov

codecovBot commented Nov 22, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2207 (432a561) into master (b26fa8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2207 +/- ##
=======================================
Coverage 97.79% 97.79% =======================================
Files 112 112 Lines 10036 10044 +8 =======================================
+ Hits 9815 9823 +8 
Misses 154 154 Partials 67 67
Impacted FilesCoverage Δ
github/actions_workflow_runs.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26fa8f...432a561. Read the comment docs.

gmlewis
gmlewis requested changes Nov 22, 2021
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xabi93 !
Just one tweak, please, then we will be ready for a second LGTM before merging.

Comment threadgithub/actions_workflow_runs.go Outdated
@x4b1@gmlewis
Fix function name godoc
432a561
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@x4b1

x4b1 commented Nov 22, 2021

Copy link
Copy Markdown
ContributorAuthor

@gmlewis done!! 😅

@x4b1
x4b1 requested a review from gmlewisNovember 22, 2021 13:14
gmlewis
gmlewis approved these changes Nov 22, 2021
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xabi93 !
LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo (we don't have to wait for anyone in particular... all contributors are welcome to participate).

wesleimp
wesleimp approved these changes Nov 25, 2021
View reviewed changes

@wesleimpwesleimp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@gmlewis

gmlewis commented Nov 26, 2021

Copy link
Copy Markdown
Collaborator

Thank you, @wesleimp !
Merging.

@gmlewis
gmlewis merged commit 59e8a37 into google:masterNov 26, 2021
@x4b1
x4b1 deleted the actions/workflows/runs/delete branch November 27, 2021 08:29
@gmlewisgmlewis mentioned this pull request Nov 29, 2021
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add function to delete a workflow run by ID (google#2207)
afc32ec
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@wesleimpwesleimpwesleimp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@x4b1@gmlewis@wesleimp