Skip to content

Add support for External Groups - #2217

Merged
gmlewis merged 9 commits into
google:masterfrom
kabesan:external-groups
Dec 23, 2021
Merged

Add support for External Groups#2217
gmlewis merged 9 commits into
google:masterfrom
kabesan:external-groups

Conversation

@kabesan

@kabesankabesan commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 5, 2021
@gmlewisgmlewis changed the title Add support External GroupsAdd support for External GroupsDec 5, 2021

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kabesan !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.

Comment threadgithub/teams.go Outdated
Comment threadgithub/teams.go Outdated
Comment threadgithub/teams.go Outdated
Comment threadgithub/teams.go Outdated
Comment threadgithub/teams.go Outdated
Comment threadgithub/teams.go Outdated
Comment threadgithub/teams_test.go
Comment threadgithub/teams_test.go
Comment threadgithub/teams_test.go
Comment threadgithub/teams_test.go
@gmlewis
gmlewis requested a review from wesleimpDecember 5, 2021 17:03
@gmlewis

Copy link
Copy Markdown
Collaborator

Also, please make sure to run unit tests before pushing (not force-pushing) your upcoming changes.
We squash and merge, so don't worry about the number of commits.
And finally, make sure to run go generate ./... and push those changes.
See our CONTRIBUTING.md file for more details.

kabesanand others added 5 commits December 6, 2021 14:54
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@kabesan

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Thank your review.
I fiexed, Please re-review.

@codecov

codecovBot commented Dec 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2217 (c0a7d7d) into master (b26fa8f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2217 +/- ##
==========================================
+ Coverage 97.79% 97.82% +0.02% 
==========================================
Files 112 112 Lines 10036 10166 +130 ==========================================
+ Hits 9815 9945 +130 
Misses 154 154 Partials 67 67 
Impacted FilesCoverage Δ
github/teams.go98.14% <100.00%> (+0.20%)⬆️
github/billing.go100.00% <0.00%> (ø)
github/projects.go96.32% <0.00%> (ø)
github/event_types.go100.00% <0.00%> (ø)
github/repos_pages.go97.11% <0.00%> (ø)
github/code-scanning.go100.00% <0.00%> (ø)
github/actions_workflow_runs.go100.00% <0.00%> (ø)
github/repos.go98.70% <0.00%> (+0.01%)⬆️
github/github.go97.62% <0.00%> (+0.02%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26fa8f...c0a7d7d. Read the comment docs.

Comment threadgithub/teams_test.go Outdated
Comment threadgithub/teams.go Outdated

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kabesan !
LGTM.

Awaiting second LGTM before merging.

(Please note that ALL other contributors to this repo are welcome to provide the second PR review/comment/approval that we need for merging and that we are not waiting for any particular reviewer unless otherwise noted.)

@kabesan

Copy link
Copy Markdown
ContributorAuthor

Fixed for diff coverage!

@kabesan

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Hi
Is second reviewer not active?
Can you add other reviewers?

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis Hi Is second reviewer not active? Can you add other reviewers?

I am no longer able to add other reviewers, but any other contributor to this repo is welcome to review.

@kabesan

Copy link
Copy Markdown
ContributorAuthor

Hi @pierce-m
Can you review this PR?
I'm waiting for second review.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @pierce-m !
Merging.

@gmlewis
gmlewis merged commit 63a1994 into google:masterDec 23, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support External Groups API

3 participants

@kabesan@gmlewis@pierce-m