Uh oh!
There was an error while loading. Please reload this page.
Add support for External Groups - #2217
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
commented
Dec 5, 2021
Also, please make sure to run unit tests before pushing (not force-pushing) your upcoming changes. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
kabesan
commented
Dec 6, 2021
@gmlewis Thank your review. |
Codecov Report
@@ Coverage Diff @@## master #2217 +/- ##
==========================================
+ Coverage 97.79% 97.82% +0.02%
==========================================
Files 112 112 Lines 10036 10166 +130 ==========================================
+ Hits 9815 9945 +130
Misses 154 154 Partials 67 67
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @kabesan !
LGTM.
Awaiting second LGTM before merging.
(Please note that ALL other contributors to this repo are welcome to provide the second PR review/comment/approval that we need for merging and that we are not waiting for any particular reviewer unless otherwise noted.)
kabesan
commented
Dec 7, 2021
Fixed for diff coverage! |
kabesan
commented
Dec 12, 2021
@gmlewis Hi |
gmlewis
commented
Dec 12, 2021
I am no longer able to add other reviewers, but any other contributor to this repo is welcome to review. |
kabesan
commented
Dec 17, 2021
Hi @pierce-m |
gmlewis
commented
Dec 23, 2021
Thank you, @pierce-m ! |
Fixes: #2213 .
https://docs.github.com/en/enterprise-cloud@latest/rest/reference/teams#external-groups