Skip to content

Add ListExternalGroupsForTeamBySlug to Teams API - #2674

Merged
gmlewis merged 1 commit into
google:masterfrom
bodgit:list-external-groups-for-team-by-slug
Mar 6, 2023
Merged

Add ListExternalGroupsForTeamBySlug to Teams API#2674
gmlewis merged 1 commit into
google:masterfrom
bodgit:list-external-groups-for-team-by-slug

Conversation

@bodgit

Copy link
Copy Markdown
Contributor

#2217 added support for the majority of the External Groups API but omitted listing groups for a specific Team within an Organization.

This PR adds the missing method, and corrects the comment on the original ListExternalGroups method as that actually returns all external groups within the Organization. I added the ForTeamBySlug suffix based on other methods in the source to distinguish it from the original method.

I've added tests based on the original ListExternalGroups method and everything passes.

@codecov

codecovBot commented Feb 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2674 (1f336cc) into master (4814a50) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2674 +/- ##
=======================================
Coverage 98.05% 98.05% =======================================
Files 131 131 Lines 11442 11455 +13 =======================================
+ Hits 11219 11232 +13 
Misses 152 152 Partials 71 71 
Impacted FilesCoverage Δ
github/teams.go98.18% <100.00%> (+0.04%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bodgit !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 24, 2023
@bodgit

Copy link
Copy Markdown
ContributorAuthor

@gmlewis good to merge now?

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 6, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 62e81bc into google:masterMar 6, 2023
@bodgit
bodgit deleted the list-external-groups-for-team-by-slug branch March 6, 2023 17:20
exageraldo pushed a commit to exageraldo/go-github that referenced this pull request Mar 13, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bodgit@gmlewis@valbeat