Skip to content

Add support for the secret scanning API - #2281

Merged
gmlewis merged 12 commits into
google:masterfrom
crqrdotcom:feat/secret-scanning-api
Feb 4, 2022
Merged

Add support for the secret scanning API#2281
gmlewis merged 12 commits into
google:masterfrom
crqrdotcom:feat/secret-scanning-api

Conversation

@crqrdotcom

@crqrdotcomcrqrdotcom commented Feb 3, 2022

Copy link
Copy Markdown

This PR adds support for the Secret Scanning API. Includes all endpoints and structures listed on the API documentation.

Closes#2278

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @crqra !

Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning.go Outdated
@codecov

codecovBot commented Feb 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2281 (000bc40) into master (e1c28bc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2281 +/- ##
==========================================
+ Coverage 97.81% 97.83% +0.01% 
==========================================
Files 114 115 +1 Lines 10266 10357 +91 ==========================================
+ Hits 10042 10133 +91 
Misses 156 156 Partials 68 68 
Impacted FilesCoverage Δ
github/github.go97.63% <100.00%> (+<0.01%)⬆️
github/secret_scanning.go100.00% <100.00%> (ø)
github/event_types.go100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c28bc...000bc40. Read the comment docs.

@gmlewisgmlewis changed the title feat: add support for the secret scanning APIAdd support for the secret scanning APIFeb 3, 2022
@crqrdotcom

Copy link
Copy Markdown
Author

Thanks for the feedback @gmlewis! I've updated the PR with your suggestions, LMK if it looks good 😄

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @crqra !
LGTM.
Awaiting second LGTM/Approval before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

@Parker77 - do you have time to review this PR?

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit a842efc into google:masterFeb 4, 2022
@crqrdotcom
crqrdotcom deleted the feat/secret-scanning-api branch February 4, 2022 16:11
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Secret Scanning endpoints

3 participants

@crqrdotcom@gmlewis@Parker77