Uh oh!
There was an error while loading. Please reload this page.
Add SecretScanningAlertEvent Webhook - #2282
Conversation
Codecov Report
@@ Coverage Diff @@## master #2282 +/- ##
=======================================
Coverage 97.83% 97.83% =======================================
Files 115 115 Lines 10360 10362 +2 =======================================
+ Hits 10136 10138 +2
Misses 156 156 Partials 68 68
Continue to review full report at Codecov.
|
IainSteers
commented
Feb 4, 2022
It looks like #2281 introduces the full SecretScanningAlert struct used in the API. I propose waiting until that merges and then I'll refactor to use it in the webhook payload. |
a9fdfaa to
e73bf7cCompareIainSteers
commented
Feb 7, 2022
@gmlewis this is good to go for review. I rebased it on Friday to use the SecretScanningAlert |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @IainSteers !
Just a couple minor tweaks, please, for the auto-generated godocs.
Also, please refrain from using force-push in this repo... we squash all commits anyway, and it is easier for the reviewers to see what changed. For more info, please see our CONTRIBUTING.md doc.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
IainSteers
commented
Feb 8, 2022
Apologies for the force-push, did it whilst rebasing without realising. I've made the corrections in punctuation. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @IainSteers!
LGTM.
Awaiting second LGTM/Approval from any other contributor of this repo before merging.
gmlewis
commented
Feb 14, 2022
Thank you, @raynigon ! |
Fixes#2277