Skip to content

Add SecretScanningAlertEvent Webhook - #2282

Merged
gmlewis merged 5 commits into
google:masterfrom
IainSteers:issue-2277-secret-scanning-alert
Feb 14, 2022
Merged

Add SecretScanningAlertEvent Webhook#2282
gmlewis merged 5 commits into
google:masterfrom
IainSteers:issue-2277-secret-scanning-alert

Conversation

@IainSteers

Copy link
Copy Markdown
Contributor

Fixes#2277

@IainSteersIainSteers changed the title issue 2277 secret scanning alertAdd SecretScanningAlertEvent WebhookFeb 4, 2022
@codecov

codecovBot commented Feb 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2282 (1c8a0ca) into master (a842efc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2282 +/- ##
=======================================
Coverage 97.83% 97.83% =======================================
Files 115 115 Lines 10360 10362 +2 =======================================
+ Hits 10136 10138 +2 
Misses 156 156 Partials 68 68 
Impacted FilesCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/messages.go100.00% <ø> (ø)
github/event.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a842efc...1c8a0ca. Read the comment docs.

@IainSteers

Copy link
Copy Markdown
ContributorAuthor

It looks like #2281 introduces the full SecretScanningAlert struct used in the API.

I propose waiting until that merges and then I'll refactor to use it in the webhook payload.

@IainSteers
IainSteersforce-pushed the issue-2277-secret-scanning-alert branch from a9fdfaa to e73bf7cCompareFebruary 4, 2022 16:23
@IainSteers

Copy link
Copy Markdown
ContributorAuthor

@gmlewis this is good to go for review. I rebased it on Friday to use the SecretScanningAlert

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IainSteers !
Just a couple minor tweaks, please, for the auto-generated godocs.
Also, please refrain from using force-push in this repo... we squash all commits anyway, and it is easier for the reviewers to see what changed. For more info, please see our CONTRIBUTING.md doc.

Comment threadgithub/event_types.go Outdated
Comment threadgithub/event_types.go Outdated
@IainSteers

Copy link
Copy Markdown
ContributorAuthor

Apologies for the force-push, did it whilst rebasing without realising. I've made the corrections in punctuation.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IainSteers!
LGTM.

Awaiting second LGTM/Approval from any other contributor of this repo before merging.

@raynigonraynigon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @raynigon !
Merging.

@gmlewis
gmlewis merged commit 41cbf81 into google:masterFeb 14, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "secret_scanning_alert" webhooks and event payloads

3 participants

@IainSteers@gmlewis@raynigon