Skip to content

Add support for setting actions permissions on a repository - #2315

Merged
gmlewis merged 10 commits into
google:masterfrom
h2floh:h2floh/2297
Mar 25, 2022
Merged

Add support for setting actions permissions on a repository#2315
gmlewis merged 10 commits into
google:masterfrom
h2floh:h2floh/2297

Conversation

@h2floh

@h2flohh2floh commented Mar 16, 2022•
edited by gmlewis
Loading

Copy link
Copy Markdown

👋 Hello there!

Couldn't find a PR for it yet so added functionality requested in #2297
Sorry if I pushed myself before @cfarrend in doing it but I will need the changes.

Went through the contributing guide and also added an example to test the change end2end.

Thanks everyone!

Fixes: #2297.

Florian Wagner
add gh actions permission for repos
16fa0b5
Signed-off-by: GitHub <noreply@github.com>
@google-cla

google-claBot commented Mar 16, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@codecov

codecovBot commented Mar 16, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2315 (ddff22b) into master (f859098) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2315 +/- ##
==========================================
+ Coverage 97.84% 97.85% +0.01% 
==========================================
Files 115 117 +2 Lines 10416 10466 +50 ==========================================
+ Hits 10192 10242 +50 
Misses 156 156 Partials 68 68
Impacted FilesCoverage Δ
github/orgs_actions_allowed.go100.00% <ø> (ø)
github/repos_actions_allowed.go100.00% <100.00%> (ø)
github/repos_actions_permissions.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f859098...ddff22b. Read the comment docs.

@h2floh

h2floh commented Mar 23, 2022

Copy link
Copy Markdown
Author

Hey @gmlewis , I signed the ICLA after my company asked me to do that. Can you please rerun the cla check. Thanks!

gmlewis
gmlewis requested changes Mar 23, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @h2floh !
Just a few tweaks, please, then we should be ready for a second review before merging.

Comment threadexample/actionpermissions/main.go Outdated
Comment threadexample/actionpermissions/main.go Outdated
Comment threadgithub/repos_actions_allowed.go Outdated
Comment threadgithub/repos_actions_allowed.go Outdated
Comment threadgithub/repos_actions_allowed.go
Comment threadgithub/repos_actions_permissions.go Outdated
Comment threadgithub/repos_actions_permissions.go
Comment threadgithub/repos_actions_permissions.go Outdated
Comment threadgithub/repos_actions_permissions.go Outdated
Comment threadgithub/repos_actions_permissions.go Outdated
Florian Wagnerand others added 8 commits March 24, 2022 12:26
Florian Wagner@gmlewis
Update example/actionpermissions/main.go
6ea25d0
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner@gmlewis
Update github/repos_actions_allowed.go
6086a7f
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner@gmlewis
Update github/repos_actions_allowed.go
a0c4e00
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner@gmlewis
Update github/repos_actions_permissions.go
ab1857e
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner@gmlewis
Update github/repos_actions_permissions.go
32583c4
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner@gmlewis
Update github/repos_actions_permissions.go
913e7f4
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Florian Wagner
err/success path patterns, linebreaks
0c83efa
Signed-off-by: GitHub <noreply@github.com>
Florian Wagner
reuse exiting functions
634f395
Signed-off-by: GitHub <noreply@github.com>
@gmlewisgmlewis mentioned this pull request Mar 24, 2022
Merged
@gmlewisgmlewis changed the title Support for setting actions permissions for a repositoryAdd support for setting actions permissions on a repositoryMar 24, 2022
gmlewis
gmlewis requested changes Mar 24, 2022
View reviewed changes
Comment threadgithub/repos_actions_allowed_test.go
Comment threadgithub/repos_actions_permissions_test.go
Florian Wagner
add missing tests
ddff22b
Signed-off-by: GitHub <noreply@github.com>
@gmlewis

gmlewis commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator

@Parker77 - do you have time for a code review?

gmlewis
gmlewis approved these changes Mar 25, 2022
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @h2floh !
LGTM.

Awaiting second LGTM before merging.

Parker77
Parker77 approved these changes Mar 25, 2022
View reviewed changes

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis

gmlewis commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 6d5a72e into google:masterMar 25, 2022
@h2floh
h2floh deleted the h2floh/2297 branch March 25, 2022 03:50
@gmlewisgmlewis mentioned this pull request Apr 30, 2022
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add support for setting actions permissions on a repository (google#2315
e300808
)
Fixes: google#2297.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@Parker77Parker77Parker77 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for setting actions permissions for a repository

3 participants

@h2floh@gmlewis@Parker77