Skip to content

Clean up method return consistency - #2318

Merged
gmlewis merged 11 commits into
google:masterfrom
gmlewis:fix-method-return-inconsistency
Mar 25, 2022
Merged

Clean up method return consistency#2318
gmlewis merged 11 commits into
google:masterfrom
gmlewis:fix-method-return-inconsistency

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

@h2floh pointed out in #2315 that our method returns are inconsistent.
This PR addresses this inconsistency.

@h2floh - please review and LGTM+Approve this PR if you agree to the changes.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

According to https://githubstatus.com , actions are currently experiencing degraded performance, which is why no tests have run as of yet.

@codecov

codecovBot commented Mar 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2318 (977aa72) into master (1694b79) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2318 +/- ##
==========================================
+ Coverage 97.95% 98.04% +0.09% 
==========================================
Files 117 117 Lines 10402 10460 +58 ==========================================
+ Hits 10189 10256 +67 + Misses 146 140 -6 + Partials 67 64 -3 
Impacted FilesCoverage Δ
github/activity_star.go100.00% <ø> (ø)
github/gists.go96.68% <ø> (ø)
github/github.go97.73% <ø> (ø)
github/orgs_members.go98.35% <ø> (ø)
github/repos_collaborators.go100.00% <ø> (ø)
github/repos_contents.go89.33% <ø> (ø)
github/billing.go100.00% <100.00%> (ø)
github/git_blobs.go100.00% <100.00%> (ø)
github/git_tags.go100.00% <100.00%> (ø)
github/issues_assignees.go100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694b79...977aa72. Read the comment docs.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@Parker77 - do you have time for a code review?

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 3e8a7f0 into google:masterMar 25, 2022
@gmlewis
gmlewis deleted the fix-method-return-inconsistency branch March 25, 2022 03:16
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@Parker77