Skip to content

Add WorkflowRun and Workflow to DeploymentEvent - #2755

Merged
gmlewis merged 5 commits into
google:masterfrom
soniachikh:add-workflow-workflowrun-to-deployment-event
Aug 15, 2023
Merged

Add WorkflowRun and Workflow to DeploymentEvent#2755
gmlewis merged 5 commits into
google:masterfrom
soniachikh:add-workflow-workflowrun-to-deployment-event

Conversation

@soniachikh

Copy link
Copy Markdown
Contributor

No description provided.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @soniachikh .
Please run go generate ./... as described in CONTRIBUTING.md and push the results to this PR.

Comment threadgithub/event_types.go
@gmlewisgmlewis changed the title add workflow run and workflow to deployment eventAdd WorkflowRun and Workflow to DeploymentEventAug 15, 2023
Comment threadgithub/event_types.go
@gmlewis

Copy link
Copy Markdown
Collaborator

@google-ospo-team - here is another PR where the googlebot has failed to comment. Please address.

@codecov

codecovBot commented Aug 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2755 (66d940c) into master (0c10d67) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2755 +/- ##
=======================================
Coverage 98.07% 98.07% =======================================
Files 139 139 Lines 12357 12357 =======================================
Hits 12119 12119 Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/event_types.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @soniachikh !
LGTM.

Awaiting response from @google-ospo-team before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

Ah! We now have the cla/google check - @soniachikh - please follow the instructions to sign the Google CLA and then we can merge this PR. Thank you!

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @soniachikh and @google-ospo-team !
CLA has been cleared.
Merging.

@gmlewis
gmlewis merged commit d00a78f into google:masterAug 15, 2023
@google-admin

Copy link
Copy Markdown
Member

FYI - there is an ongoing issue with GitHub webhooks (https://www.githubstatus.com/) that is likely causing the delays in the CLA check running.

@stockmaj

Copy link
Copy Markdown

@gmlewis is there a plan to release soon? I see it's been a while.

@stockmaj
stockmaj deleted the add-workflow-workflowrun-to-deployment-event branch August 16, 2023 15:38
@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis is there a plan to release soon? I see it's been a while.

Yes, you are right, and we've had a lot of activity in the repo since the last release.
It would be nice to get #2865 and #2869 reviewed and merged... and maybe even #2876 .
If you could assist by reviewing the outstanding PRs, that would help tremendously.
Thank you!

@gmlewis

Copy link
Copy Markdown
Collaborator

@stockmaj

Copy link
Copy Markdown

Thank you.

gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@soniachikh@gmlewis@google-admin@stockmaj