Skip to content

Add support for fetching SBOMs - #2869

Merged
gmlewis merged 17 commits into
google:masterfrom
vandanrohatgi:get-sbom
Aug 16, 2023
Merged

Add support for fetching SBOMs#2869
gmlewis merged 17 commits into
google:masterfrom
vandanrohatgi:get-sbom

Conversation

@vandanrohatgi

@vandanrohatgivandanrohatgi commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Closes#2864

Adds support for fetching Software Bill of materials (SBOM) for a repository.

  • go generate
  • go test
  • go vet

Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/github.go
Comment threadgithub/github.go
vandanrohatgiand others added 12 commits August 14, 2023 19:09
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov

codecovBot commented Aug 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2869 (c48702b) into master (3ecf12c) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2869 +/- ##
==========================================
- Coverage 98.07% 98.06% -0.02% 
==========================================
Files 139 140 +1 Lines 12348 12269 -79 ==========================================
- Hits 12110 12031 -79 
Misses 162 162 Partials 76 76 
Files ChangedCoverage Δ
github/dependency_graph.go100.00% <100.00%> (ø)
github/github.go97.97% <100.00%> (+<0.01%)⬆️

... and 6 files with indirect coverage changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
Just a couple minor comment nits, please, that I apparently missed the first time
before we await a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 15, 2023
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi

Copy link
Copy Markdown
ContributorAuthor

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

No, not at all, @vandanrohatgi ! Your contributions are appreciated more than you know!
I couldn't maintain this repo without the help of wonderful contributors like yourself.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis changed the title Add support for fetching sbomsAdd support for fetching SBOMsAug 15, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

@Parker77 - do you have time for a code review, please?

Comment threadgithub/dependency_graph.go Outdated
Co-authored-by: Parker77 <20973702+Parker77@users.noreply.github.com>

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @Parker77 !
Merging.

@gmlewis
gmlewis merged commit 0c562f6 into google:masterAug 16, 2023
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Repository SBOM generation

3 participants

@vandanrohatgi@gmlewis@Parker77