Uh oh!
There was an error while loading. Please reload this page.
Add CreateOrUpdateCustomPropertyValues for repositories - #3105
Add CreateOrUpdateCustomPropertyValues for repositories#3105HariCharanK wants to merge 10 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3105 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84%
==========================================
Files 153 170 +17 Lines 13390 11426 -1964 ==========================================
- Hits 13085 10613 -2472 - Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
gmlewis
commented
Mar 16, 2024
If you could revert all the changes that are already covered by #3104, that would be great. Just a heads-up... we try to avoid using |
The changes in this depend on changes in #3104, so we should wait until it's merged. I don't see otherwise. " |
HariCharanK
commented
Apr 22, 2024
resolved merge conflicts. |
gmlewis
commented
Apr 22, 2024
@HariCharan-001 - as far as I can tell, this PR is not addressing the issue in #3101 which is to add a PATCH endpoint for this: https://docs.github.com/en/rest/repos/custom-properties?apiVersion=2022-11-28#create-or-update-custom-property-values-for-a-repository |
HariCharanK
commented
Apr 22, 2024
@gmlewis Do you think it is necessary to avoid using interface{} in this particular scenario ? |
gmlewis
commented
Apr 22, 2024
The |
gmlewis
commented
Jan 22, 2025
I will close this PR around the end of January, 2025 as "abandoned" if there is no further response. |
gmlewis
commented
Feb 5, 2025
Closing PR as abandoned. |
Fixes:
#3101
Followup PR to #3104
Used
interface{}type forPropertyValueas it can be string, array or null according to the GitHub documentation here.In Go, an
interface{}can hold any type, including an array (or slice) of strings.