Skip to content

feat!: Update deprecated endpoints in github/action_variables.go - #3104

Merged
gmlewis merged 7 commits into
google:masterfrom
HariCharanK:haricharan
Mar 28, 2024
Merged

feat!: Update deprecated endpoints in github/action_variables.go#3104
gmlewis merged 7 commits into
google:masterfrom
HariCharanK:haricharan

Conversation

@HariCharanK

@HariCharanKHariCharanK commented Mar 16, 2024•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

Fixes:
#3103

BREAKING-CHANGE: The following endpoints now take owner and repo names instead of an integer repo ID:

  • ActionsService.ListEnvVariables
  • ActionsService.GetEnvVariable
  • ActionsService.CreateEnvVariable
  • ActionsService.UpdateEnvVariable
  • ActionsService.DeleteEnvVariable

@HariCharanKHariCharanK mentioned this pull request Mar 16, 2024
Closed
@codecov

codecovBot commented Mar 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (eefe111).
Report is 23 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3104 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86% 
==========================================
Files 153 170 +17 Lines 13390 11403 -1987 ==========================================
- Hits 13085 10590 -2495 - Misses 215 723 +508 
Partials 90 90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HariCharanKHariCharanK mentioned this pull request Mar 16, 2024
Closed
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Mar 16, 2024
@gmlewisgmlewis changed the title Update deprecated endpoints in github/action_variables.gofeat!: Update deprecated endpoints in github/action_variables.goMar 16, 2024
gmlewis
gmlewis approved these changes Mar 16, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HariCharan-001 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@HariCharanK

HariCharanK commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @gmlewis
The second approval is still pending. Just letting you know, in case.

Can you tag anyone you know ?

@gmlewis

gmlewis commented Mar 20, 2024

Copy link
Copy Markdown
Collaborator

I try to not bother volunteers since this repo has a rather high traffic of PRs (in my opinion).
Feel free to ask any developer you know to provide a code review.

@gmlewis

gmlewis commented Mar 28, 2024

Copy link
Copy Markdown
Collaborator

This is holding up other PRs like #3109.
Merging.

@gmlewis
gmlewis merged commit 8c1032a into google:masterMar 28, 2024
This was referenced Mar 28, 2024
Merged
Merged
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: Update deprecated endpoints in github/action_variables.go (goo…
c1a7023
…gle#3104)
Fixes: google#3103.
BREAKING-CHANGE: The following endpoints now take `owner` and `repo` (string) names instead of an integer repo ID:
ActionsService.ListEnvVariables
ActionsService.GetEnvVariable
ActionsService.CreateEnvVariable
ActionsService.UpdateEnvVariable
ActionsService.DeleteEnvVariable
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HariCharanK@gmlewis