Add CreateOrUpdateRepoCustomPropertyValues

[ganeshkumarsv]

Adds method CreateOrUpdateRepoCustomPropertyValues

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (471ec26).
Report is 30 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #3109 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11423 -1967 ==========================================
- Hits 13085 10610 -2475 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmlewis]

Thank you, @ganeshkumarsv !
I saw the commit titled "no idea what im doing" and thought I might help out... In CONTRIBUTING.md, we have some helpful tips that should assist you. Please let me know if you have any question, but it looks like you are on the right track. You can also look at some of the other files for examples on code coverage.

[ganeshkumarsv]

Thank you, @ganeshkumarsv ! I saw the commit titled "no idea what im doing" and thought I might help out... In CONTRIBUTING.md, we have some helpful tips that should assist you. Please let me know if you have any question, but it looks like you are on the right track. You can also look at some of the other files for examples on code coverage.

Thanks for commenting @gmlewis. Running metadata.sh makes modification for a lot of URLs and erroring out. I don't see a way to update openapi configs only the one endpoint i'm updating. Any help appreciated. Thank you 🙇

[gmlewis]

Thanks for commenting @gmlewis. Running metadata.sh makes modification for a lot of URLs and erroring out. I don't see a way to update openapi configs only the one endpoint i'm updating. Any help appreciated. Thank you 🙇

You shouldn't have to deal with the metadata or OpenAPI stuff... you should only have to make sure your formatting has been fixed and the generator has been run, and you can revert any changes made to the metadata.

[ganeshkumarsv]

I tried running go run github/gen-accessors.go but it is not generating anything. Am i missing something?

[ganeshkumarsv]

I removed my changes from openapi_operations.yaml as u mentioned. The linter fails with the error could not find operation "PATCH /repos/{owner}/{repo}/properties/values" in openapi_operations.yaml

Can I know how i can fix this error?

[gmlewis]

@ganeshkumarsv - now that #3104 is merged, please try to update this branch using git merge master and see if that solves the problems you were seeing before.

[ganeshkumarsv]

Thanks @gmlewis. I updated the branch and it fixed the linter. All the checks are passing now.

[gmlewis]

Thank you, @ganeshkumarsv !
Just one minor tweak, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[gmlewis]

Thank you, @ganeshkumarsv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[ganeshkumarsv]

@liaodaniel I need one more approval to merge this PR. Can you please review? 🙇

[ganeshkumarsv]

@gmlewis we got 2 reviews for the PR. Can you please merge if everything looks ok?

[gmlewis]

Thank you, @AbbanMustafa !
Merging.

[ganeshkumarsv]

@gmlewis Thanks for merging. Is it possible to create a new release?

[gmlewis]

@gmlewis Thanks for merging. Is it possible to create a new release?

This is now released in v61: https://github.com/google/go-github/releases/tag/v61.0.0