Skip to content

feat!: Change enterprise runner to also use ListRunnersOptions - #3167

Merged
gmlewis merged 1 commit into
google:masterfrom
ponkio-o:fix/consider-ent-runner
May 13, 2024
Merged

feat!: Change enterprise runner to also use ListRunnersOptions#3167
gmlewis merged 1 commit into
google:masterfrom
ponkio-o:fix/consider-ent-runner

Conversation

@ponkio-o

@ponkio-oponkio-o commented May 13, 2024•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

Fixes: #3166.

BREAKING-CHANGE: This changes ListOptions to ListRunnersOptions in EnterpriseService.ListRunners.

I fixed a bug related ListRunners API. The ListRunnersOptions was not being applied to Enterprise Runner.
follow up: #3094

@google-cla

google-claBot commented May 13, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ponkio-oponkio-o mentioned this pull request May 13, 2024
Closed
@gmlewisgmlewis changed the title fix: changed enterprise runner to also use ListRunnersOptionsfeat!: Change enterprise runner to also use ListRunnersOptionsMay 13, 2024
@codecov

codecovBot commented May 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (2b8c7fa) to head (00ae280).
Report is 59 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3167 +/- ##
==========================================
- Coverage 97.72% 92.91% -4.81% 
==========================================
Files 153 171 +18 Lines 13390 11502 -1888 ==========================================
- Hits 13085 10687 -2398 - Misses 215 724 +509 - Partials 90 91 +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). waiting for signed CLA labels May 13, 2024
@ponkio-o

ponkio-o commented May 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Sorry, I just completed signing the CLA.

gmlewis
gmlewis approved these changes May 13, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ponkio-o !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis

gmlewis commented May 13, 2024

Copy link
Copy Markdown
Collaborator

@fentas - perhaps you are available to review this?

fentas
fentas approved these changes May 13, 2024
View reviewed changes

@fentasfentas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 13, 2024
@gmlewis

gmlewis commented May 13, 2024

Copy link
Copy Markdown
Collaborator

Thank you, @fentas ! Merging.

@gmlewis
gmlewis merged commit 4169a9c into google:masterMay 13, 2024
@ponkio-o
ponkio-o deleted the fix/consider-ent-runner branch May 13, 2024 11:28
@gmlewisgmlewis mentioned this pull request Jul 10, 2024
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: Change enterprise runner to also use ListRunnersOptions (googl…
31d7560
…e#3167)
Fixes: google#3166.
BREAKING-CHANGE: This changes `ListOptions` to `ListRunnersOptions` in `EnterpriseService.ListRunners`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@fentasfentasfentas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListRunnersOption change omits consideration of Enterprise Runner

3 participants

@ponkio-o@gmlewis@fentas