Skip to content

feat!: Add ListRunnersOptions to support all query parameters - #3094

Merged
gmlewis merged 2 commits into
google:masterfrom
fentas:ListRunnersOptions
May 1, 2024
Merged

feat!: Add ListRunnersOptions to support all query parameters#3094
gmlewis merged 2 commits into
google:masterfrom
fentas:ListRunnersOptions

Conversation

@fentas

@fentasfentas commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3093.

BREAKING-CHANGE: This changes ListOptions to ListRunnersOptions in ListRunners and ListOrganizationRunners.

Let me know if something is missing 🙌

Edit: I agreed to the CLA.

@google-cla

google-claBot commented Mar 5, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Mar 5, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fentas !
One tweak, please, then you will need to update your tests and run step 4 scripts listed in CONTRIBUTING.md.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

I'll also change the PR title to note that this is a breaking API change.

Comment threadgithub/actions_runners.go Outdated
@gmlewisgmlewis changed the title Add ListRunnersOptions to support all query parametersfeat!: Add ListRunnersOptions to support all query parametersMar 5, 2024
@fentas
fentasforce-pushed the ListRunnersOptions branch from 8c8f016 to 765fbf8CompareMarch 5, 2024 12:04
@codecov

codecovBot commented Mar 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (843b6c4).
Report is 23 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3094 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86% 
==========================================
Files 153 170 +17 Lines 13390 11403 -1987 ==========================================
- Hits 13085 10590 -2495 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

Just for future reference, you never need to force push to PRs in this repo (and we prefer if you don't to make reviews easier to see what changed) because we always squash and merge here. Thanks.
Obviously, no big deal in this case. 😁

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fentas !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@be0x74abe0x74a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @be0x74a !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 1, 2024
@gmlewis
gmlewis merged commit faffd29 into google:masterMay 1, 2024
ponkio-o added a commit to ponkio-o/go-github that referenced this pull request May 13, 2024
@fentas
fentas deleted the ListRunnersOptions branch May 13, 2024 07:58
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…#3094)
Fixes: google#3093.
BREAKING-CHANGE: This changes `ListOptions` to `ListRunnersOptions` in `ListRunners` and `ListOrganizationRunners`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List[Organization]Runners does not support all query parameters

3 participants

@fentas@gmlewis@be0x74a