Skip to content

Add role name to Repo permissions level struct - #3186

Closed
ankitsultania wants to merge 1 commit into
google:masterfrom
ankitsultania:patch-1
Closed

Add role name to Repo permissions level struct#3186
ankitsultania wants to merge 1 commit into
google:masterfrom
ankitsultania:patch-1

Conversation

@ankitsultania

@ankitsultaniaankitsultania commented Jun 11, 2024

Copy link
Copy Markdown

Fixes: #3189.

I am currently using this API to fetch what role does a user have on a repository. AFAICS, RepositoryPermissionLevel struct is missing role_name which is provided by the API (https://docs.github.com/en/rest/collaborators/collaborators?apiVersion=2022-11-28#get-repository-permissions-for-a-user). Due, to this I am unable to use the library. This PR introduces the field within the RepositoryPermissionLevel struct

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ankitsultania !
Please run step 4 found in CONTRIBUTING.md and push the auto-generated changes to this PR. Then, once the CLA is signed, we can merge.

@codecov

codecovBot commented Jun 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (2b8c7fa) to head (1370675).
Report is 70 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3186 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82% 
==========================================
Files 153 171 +18 Lines 13390 11548 -1842 ==========================================
- Hits 13085 10729 -2356 - Misses 215 726 +511 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitsultania

Copy link
Copy Markdown
Author

closing this out and will work on my other PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RepositoryPermissionLevel is missing role_name

2 participants

@ankitsultania@gmlewis