Skip to content

Add role name to RepositoryPermissionLevel - #3188

Merged
gmlewis merged 2 commits into
google:masterfrom
asultania-sc:patch-2
Jun 12, 2024
Merged

Add role name to RepositoryPermissionLevel#3188
gmlewis merged 2 commits into
google:masterfrom
asultania-sc:patch-2

Conversation

@asultania-sc

@asultania-scasultania-sc commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3189.

I am currently using this API to fetch what role does a user have on a repository. AFAICS, RepositoryPermissionLevel struct is missing role_name which is provided by the API (https://docs.github.com/en/rest/collaborators/collaborators?apiVersion=2022-11-28#get-repository-permissions-for-a-user). Due, to this I am unable to use the library. This PR introduces the field within the RepositoryPermissionLevel struct

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis

Copy link
Copy Markdown
Collaborator

It looks like this might be a duplicate of #3186.

Please run step 4 found in CONTRIBUTING.md and push the auto-generated changes to this PR. Then, once the CLA is signed, we can merge.

@codecov

codecovBot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (2b8c7fa) to head (007e8e8).
Report is 70 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3188 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82% 
==========================================
Files 153 171 +18 Lines 13390 11548 -1842 ==========================================
- Hits 13085 10729 -2356 - Misses 215 726 +511 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @asultania-sc !
LGTM.
Merging.

@gmlewis
gmlewis merged commit a2b2fc8 into google:masterJun 12, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RepositoryPermissionLevel is missing role_name

2 participants

@asultania-sc@gmlewis