Skip to content

feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization - #3197

Merged
gmlewis merged 2 commits into
google:masterfrom
laughedelic:feat/team-sync-groups/q-param
Jul 24, 2024
Merged

feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization#3197
gmlewis merged 2 commits into
google:masterfrom
laughedelic:feat/team-sync-groups/q-param

Conversation

@laughedelic

@laughedeliclaughedelic commented Jul 5, 2024•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

Fixes#3196.

BREAKING CHANGE: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization

I followed the template of this PR, fixing a similar issue: #3094.

Let me know if there is a better way to handle this. And I'm open to better naming suggestions.

@google-cla

google-claBot commented Jul 5, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Jul 5, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (2b8c7fa) to head (e492cdd).
Report is 76 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3197 +/- ##
==========================================
- Coverage 97.72% 92.91% -4.81% 
==========================================
Files 153 171 +18 Lines 13390 11558 -1832 ==========================================
- Hits 13085 10739 -2346 - Misses 215 726 +511 - Partials 90 93 +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis changed the title feat!: add ListIDPGroupsOptions to support the filtering parameterfeat!: Replace ListOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganizationJul 5, 2024
gmlewis
gmlewis requested changes Jul 5, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @laughedelic .
One minor change, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/teams.go Outdated
@laughedelic
laughedelic requested a review from gmlewisJuly 5, 2024 18:37
gmlewis
gmlewis approved these changes Jul 5, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @laughedelic !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jul 5, 2024
@gmlewisgmlewis changed the title feat!: Replace ListOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganizationfeat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganizationJul 5, 2024
@laughedeliclaughedelic mentioned this pull request Jul 10, 2024
Open
1 task
@laughedelic

laughedelic commented Jul 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi! Is there anything I can do to move this forward?

@gmlewis

gmlewis commented Jul 23, 2024

Copy link
Copy Markdown
Collaborator

Hi! Is there anything I can do to move this forward?

If you have any coworkers or know of any other contributors to this repo (who are all volunteers, please remember), feel free to reach out to request a code review if you are comfortable with that.

arymoraes
arymoraes approved these changes Jul 24, 2024
View reviewed changes

@arymoraesarymoraes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 24, 2024
@gmlewis

gmlewis commented Jul 24, 2024

Copy link
Copy Markdown
Collaborator

Thank you, @arymoraes !
Merging.

@gmlewis
gmlewis merged commit 2cdb0ea into google:masterJul 24, 2024
@gmlewisgmlewis mentioned this pull request Aug 21, 2024
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsSe…
6624050
…rvice.ListIDPGroupsInOrganization (google#3197)
Fixesgoogle#3196.
BREAKING CHANGE: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@arymoraesarymoraesarymoraes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListIDPGroupsInOrganization is missing the filter parameter

3 participants

@laughedelic@gmlewis@arymoraes