Skip to content

Add support DeploymentReview Event, ReviewCustomDeploymentProtectionRule API, GetPendingDeployments API - #3254

Merged
gmlewis merged 6 commits into
google:masterfrom
air-hand:feat/issue-3252
Sep 26, 2024
Merged

Add support DeploymentReview Event, ReviewCustomDeploymentProtectionRule API, GetPendingDeployments API#3254
gmlewis merged 6 commits into
google:masterfrom
air-hand:feat/issue-3252

Conversation

@air-hand

@air-handair-hand commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

@air-handair-hand changed the title WIP issue-3252Add support DeploymentReview Event, ReviewCustomDeploymentProtectionRule API, GetPendingDeployments APISep 3, 2024
@air-hand
air-hand marked this pull request as ready for review September 3, 2024 13:05
@codecov

codecovBot commented Sep 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (2328ae7).
Report is 105 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3254 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.77% 
==========================================
Files 153 171 +18 Lines 13390 11680 -1710 ==========================================
- Hits 13085 10857 -2228 - Misses 215 729 +514 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 3, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @air-hand, this is looking great!
Just a couple minor nits to address, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/actions_workflow_runs.go
Comment threadgithub/actions_workflow_runs.go Outdated
@air-hand

Copy link
Copy Markdown
ContributorAuthor

Thank you, @air-hand, this is looking great! Just a couple minor nits to address, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Thanks for the review!
I have applied your suggestions.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @air-hand !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@air-hand

Copy link
Copy Markdown
ContributorAuthor

Hello, @gmlewis.

I am waiting for a second LGTM+ approval from other contributors to this repository before merging it.

I know this repository is supported by volunteers, but I want to release this.
If possible, could you please tell me how to find a second reviewer as PR author? 🙏

@gmlewis

Copy link
Copy Markdown
Collaborator

If possible, could you please tell me how to find a second reviewer as PR author?

Do you have a coworker you could ask to perform the code review?

@air-hand

Copy link
Copy Markdown
ContributorAuthor

Do you have a colleague you can ask to review code?

Probably not.
I think that PR reviewers for this repository must be contributors, cause I can't assign myself as a reviewer other PR just now.

@gmlewis

Copy link
Copy Markdown
Collaborator

I think that PR reviewers for this repository must be contributors, cause I can't assign myself as a reviewer other PR just now.

We welcome new contributors to this repo all the time. All new Go developers are welcome to contribute with PRs or code reviews. See CONTRIBUTING.md for more information.

@air-hand

Copy link
Copy Markdown
ContributorAuthor

Oh, I mean that a user who has never committed to the default branch (i.e., a user who is not listed as a "contributor") may not be able to assign itself as a reviewer on github because I have tried other PR but I couldn't.

@gmlewis

Copy link
Copy Markdown
Collaborator

I've asked @srgustafson8 if a code review might be possible since @srgustafson8 is actively working on other PRs right now...

@gmlewis

Copy link
Copy Markdown
Collaborator

Oh, I mean that a user who has never committed to the default branch (i.e., a user who is not listed as a "contributor") may not be able to assign itself as a reviewer on github because I have tried other PR but I couldn't.

Just FYI - it is almost never necessary that a reviewer be assigned in this repo on any particular PR.
We welcome all code reviews and rarely ever assign specific reviewers.

@gmlewis

Copy link
Copy Markdown
Collaborator

In fact, @air-hand - please feel free to perform code reviews yourself on any open PRs that have the "Needs Review" label... all contributions are greatly appreciated!

@air-hand

Copy link
Copy Markdown
ContributorAuthor

Just FYI - it is almost never necessary that a reviewer be assigned in this repo on any particular PR.

Thanks @gmlewis, I finally understand. (I had always assign reviewer myself on PR before code review...)

@gmlewis

Copy link
Copy Markdown
Collaborator

Thanks @gmlewis, I finally understand. (I had always assign reviewer myself on PR before code review...)

Yes, that is totally reasonable and quite common especially in a corporate environment.
No worries at all. Thanks again for all your help to make this repo better! It is greatly appreciated.

@srgustafson8

Copy link
Copy Markdown
Contributor

@air-hand@gmlewis will try and get to this one today :)

@srgustafson8srgustafson8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 looks good to me

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 26, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @srgustafson8 !
Merging.

@gmlewis
gmlewis merged commit 3d410c2 into google:masterSep 26, 2024
gmlewis pushed a commit that referenced this pull request Oct 1, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: support Deployment Review Event, Review Custom Deployment Protection Rule API

3 participants

@air-hand@gmlewis@srgustafson8