Uh oh!
There was an error while loading. Please reload this page.
feat: Implement missing push rules - #3294
Conversation
srgustafson8
commented
Sep 25, 2024
Tests output: |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @srgustafson8 !
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
If you have a moment, would you mind taking a look at some of the other outstanding PRs and give them code reviews, please? Of note is #3254 where the author is expressing desire to merge ASAP. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3294 +/- ##
==========================================
- Coverage 97.72% 93.01% -4.72%
==========================================
Files 153 171 +18 Lines 13390 11777 -1613 ==========================================
- Hits 13085 10954 -2131 - Misses 215 729 +514 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @srgustafson8 !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
commented
Oct 1, 2024
Thank you, @tomfeigin and @air-hand ! |
Adds support for the missing Push Rules - Restrict file path length, Restrict file extensions and Restrict file size with tests.
Closes#3274