Skip to content

feat: Add support for code_scanning - #3256

Merged
gmlewis merged 8 commits into
google:masterfrom
ihor-hrytskiv:feat/code-scanning-rulesets
Oct 17, 2024
Merged

feat: Add support for code_scanning#3256
gmlewis merged 8 commits into
google:masterfrom
ihor-hrytskiv:feat/code-scanning-rulesets

Conversation

@ihor-hrytskiv

Copy link
Copy Markdown
Contributor

Suggestion to add support for code_scanning in Github API.

Ruleset API docs

@google-cla

google-claBot commented Sep 3, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>
@ihor-hrytskiv
ihor-hrytskivforce-pushed the feat/code-scanning-rulesets branch from 9c450af to 0dba8daCompareSeptember 3, 2024 14:58
@codecov

codecovBot commented Sep 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (2b8c7fa) to head (10a26f4).
Report is 155 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3256 +/- ##
==========================================
- Coverage 97.72% 93.42% -4.30% 
==========================================
Files 153 172 +19 Lines 13390 11922 -1468 ==========================================
- Hits 13085 11138 -1947 - Misses 215 691 +476 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv!
One minor tweak, please, and also make sure to read step 4 of CONTRIBUTING.md and push (not force-push) the changes to this PR.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/repos_rules.go Outdated
@ihor-hrytskiv

Copy link
Copy Markdown
ContributorAuthor

Thank you, @ihor-hrytskiv! One minor tweak, please, and also make sure to read step 4 of CONTRIBUTING.md and push (not force-push) the changes to this PR.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Thank you, @gmlewis and sorry for force-push

Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 3, 2024
ihor-hrytskivand others added 4 commits September 4, 2024 09:46
Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>
Signed-off-by: Ihor Hrytskiv <ihor.hrytskiv@macpaw.com>
@gmlewis

Copy link
Copy Markdown
Collaborator

@ihor-hrytskiv - can you please resolve the conflicts in this PR and push (not force-push) the updates when you get a chance? Hopefully we will then get a second LGTM+Approval and can proceed to merge. Thank you!

@air-handair-hand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
}),
},
"Invalid Required workflows params": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 17, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @air-hand !
Updating branch...

@gmlewis
gmlewis merged commit 8c273e1 into google:masterOct 17, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ihor-hrytskiv@gmlewis@air-hand