Skip to content

feat!: Rename code scanning params from plural to singular - #3331

Merged
gmlewis merged 2 commits into
google:masterfrom
ihor-hrytskiv:fix/code-scanning-rulesets
Oct 22, 2024
Merged

feat!: Rename code scanning params from plural to singular#3331
gmlewis merged 2 commits into
google:masterfrom
ihor-hrytskiv:fix/code-scanning-rulesets

Conversation

@ihor-hrytskiv

@ihor-hrytskivihor-hrytskiv commented Oct 21, 2024•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: Rename RuleRequiredCodeScanningTools to RuleRequiredCodeScanningTool.

Some improvements for #3256

@gmlewisgmlewis changed the title feat!: rename code scanning params from plural to singularfeat!: Rename code scanning params from plural to singularOct 21, 2024
gmlewis
gmlewis requested changes Oct 21, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv.
One minor suggestion, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/repos_rules.go Outdated
@codecov

codecovBot commented Oct 21, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (2b8c7fa) to head (cf59fc6).
Report is 158 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3331 +/- ##
==========================================
- Coverage 97.72% 93.01% -4.71% 
==========================================
Files 153 172 +19 Lines 13390 14848 +1458 ==========================================
+ Hits 13085 13811 +726 - Misses 215 944 +729 - Partials 90 93 +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihor-hrytskiv@gmlewis
Update github/repos_rules.go
cf59fc6
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
gmlewis approved these changes Oct 21, 2024
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Oct 21, 2024
@ihor-hrytskiv

ihor-hrytskiv commented Oct 22, 2024

Copy link
Copy Markdown
ContributorAuthor

@air-hand Could you review please?

air-hand
air-hand approved these changes Oct 22, 2024
View reviewed changes

@air-handair-hand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 22, 2024
@gmlewis

gmlewis commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator

Thank you, @air-hand !
Merging.

@gmlewis
gmlewis merged commit 792bd15 into google:masterOct 22, 2024
@gmlewisgmlewis mentioned this pull request Nov 27, 2024
Merged
@nickfloydnickfloyd mentioned this pull request Oct 23, 2025
Closed
1 task
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: Rename code scanning params from plural to singular (google#3331)
2aca949
BREAKING CHANGE: Rename `RuleRequiredCodeScanningTools` to `RuleRequiredCodeScanningTool`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@air-handair-handair-hand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ihor-hrytskiv@gmlewis@air-hand