Skip to content

feat: Implement organization role assignments for both users and teams - #3281

Merged
gmlewis merged 4 commits into
google:masterfrom
felixlut:organization-role-assignments
Sep 23, 2024
Merged

feat: Implement organization role assignments for both users and teams#3281
gmlewis merged 4 commits into
google:masterfrom
felixlut:organization-role-assignments

Conversation

@felixlut

Copy link
Copy Markdown
Contributor

resolves#3280

@felixlut

felixlut commented Sep 21, 2024

Copy link
Copy Markdown
ContributorAuthor

While working on this I noticed that the file naming is slightly off from how GitHub structures their API:s. There's a difference between repository roles and organization roles, but currently the orgs_custom_roles.go file is dealing with both (even before my changes). It should probably be split up into orgs_repo_roles.go and orgs_org_roles.go (or maybe flip the order to orgs_role_{org/repo}.go to keep the files "closer together"), similarily to integrations/terraform-provider-github#2224.

Leaving it up to the reviewer to decide if this should be done in this PR directly or in a separate one later

@gmlewisgmlewis changed the title feat: implement organization role assignments for both users and teamsfeat: Implement organization role assignments for both users and teamsSep 21, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Leaving it up to the reviewer to decide if this should be done in this PR directly or in a separate one later

Please perform the reorganization in your next PR. Thank you!

@codecov

codecovBot commented Sep 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (2b8c7fa) to head (93c9317).
Report is 120 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3281 +/- ##
==========================================
- Coverage 97.72% 92.96% -4.76% 
==========================================
Files 153 171 +18 Lines 13390 11705 -1685 ==========================================
- Hits 13085 10882 -2203 - Misses 215 729 +514 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo.

Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 21, 2024
felixlutand others added 3 commits September 22, 2024 10:45
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@felixlut

Copy link
Copy Markdown
ContributorAuthor

@gmlewis done!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 23, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support assigning organization roles to teams and users

3 participants

@felixlut@gmlewis@tomfeigin