Uh oh!
There was an error while loading. Please reload this page.
refactor: Refactor org_custom_roles.go into multiple files - #3291
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @felixlut !
Any time a new file is created, we bump the copyright year to the current year, but if a file is renamed or otherwise edited, we leave the copyright year alone...
So just a couple minor nits, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #3291 +/- ##
==========================================
- Coverage 97.72% 92.97% -4.75%
==========================================
Files 153 172 +19 Lines 13390 11715 -1675 ==========================================
- Hits 13085 10892 -2193 - Misses 215 729 +514 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
commented
Oct 1, 2024
Thank you, @tomfeigin ! |
Continuation of #3281 (comment)
The
/organizations/ORGANIZATION_ID/custom_rolesendpoint has been deprecated in favor of/orgs/ORG/custom-repository-roles. So theorgs_custom_roles.gofile should be refactored. The file also deals with Organization roles, which is a separate kind of resource to the Organization Repository Roles. For this reason this PR aims to separate the file into two:orgs_custom_repository_roles.go- API docs -/orgs/ORG/custom-repository-rolesorgs_organization_roles.go- API docs -/orgs/ORG/organization-roles