Uh oh!
There was an error while loading. Please reload this page.
feat: Add assignment for org role associations - #3371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3371 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42%
==========================================
Files 153 176 +23 Lines 13390 15031 +1641 ==========================================
+ Hits 13085 13874 +789 - Misses 215 1064 +849 - Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
7b7c2be to
1c73510Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell !
LGTM.
Merging.
| Assignment *string `json:"assignment,omitempty"` | ||
| // InheritedFrom identifies the team that a user inherited their organization role | ||
| // from. This is only populated when calling the ListUsersAssignedToOrgRole method. | ||
| InheritedFrom *Team `json:"inherited_from,omitempty"` |
There was a problem hiding this comment.
@stevehipwell the inherited_from field returns for me as an array which fails the unmarshalling, are you sure you got only a single team in the API result?
There was a problem hiding this comment.
I think the schema might have changed as it's now looks like an array, but I'm pretty sure I tested this.
There was a problem hiding this comment.
I want to change this field to an array can you verify it doesn't break anything for you? I want to know if we need to support both cases
Resolves#3364
This PR adds the
Assignmentfield toTeam&Userand theInheritedFromfield toUserwhen accessed in the context of an organization role.