Skip to content

feat!: Change User.InheritedFrom to a slice - #3460

Merged
gmlewis merged 1 commit into
google:masterfrom
tomfeigin:inherited-from-array
Feb 5, 2025
Merged

feat!: Change User.InheritedFrom to a slice#3460
gmlewis merged 1 commit into
google:masterfrom
tomfeigin:inherited-from-array

Conversation

@tomfeigin

@tomfeigintomfeigin commented Feb 5, 2025•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: User.InheritedFrom is changed from a *Team to a []*Team.

@tomfeigintomfeigin mentioned this pull request Feb 5, 2025
Merged
@stevehipwell

stevehipwell commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

@tomfeigin this looks good to me (I've checked the API directly). I've not managed to use the code yet and it looks like I made a mistake as the schema has this as an array on December 2nd when I opened the original issue.

@gmlewis could you take a look at this please?

@codecov

codecovBot commented Feb 5, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (d392e2c) to head (22c1ed3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3460 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15535 15535 =======================================
Hits 14142 14142 Misses 1221 1221 Partials 172 172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). and removed NeedsReview PR is awaiting a review before merging. labels Feb 5, 2025
@gmlewisgmlewis changed the title Change InheritedFrom to a slicefeat!: Change User.InheritedFrom to a sliceFeb 5, 2025
gmlewis
gmlewis approved these changes Feb 5, 2025
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin and @stevehipwell!
LGTM.
Merging.

@gmlewis
gmlewis merged commit a8a3177 into google:masterFeb 5, 2025
@tomfeigin

tomfeigin commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

@gmlewis thank you :) will you release a new version with the fix?

@gmlewisgmlewis mentioned this pull request Feb 5, 2025
Merged
@gmlewis

gmlewis commented Feb 5, 2025

Copy link
Copy Markdown
Collaborator

@gmlewis thank you :) will you release a new version with the fix?

This is now available here: https://github.com/google/go-github/releases/tag/v69.0.0

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: ChangeUser.InheritedFromto a slice (google#3460)
8583ecb
BREAKING CHANGE: `User.InheritedFrom` is changed from a `*Team` to a `[]*Team`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomfeigin@stevehipwell@gmlewis