Skip to content

feat: Add link to bored-engineer/github-conditional-http-transport to conditional requests documentation - #3469

Merged
gmlewis merged 6 commits into
google:masterfrom
bored-engineer:patch-2
Feb 8, 2025
Merged

feat: Add link to bored-engineer/github-conditional-http-transport to conditional requests documentation#3469
gmlewis merged 6 commits into
google:masterfrom
bored-engineer:patch-2

Conversation

@bored-engineer

@bored-engineerbored-engineer commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

See #3468 for more discussion/details.

Fixes: #3468.

@codecov

codecovBot commented Feb 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (0ccbfaf) to head (6db7e25).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3469 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15538 15538 =======================================
Hits 14145 14145 Misses 1221 1221 Partials 172 172 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

Please run go generate ./... and push the changes to this PR. (See step 4 of CONTRIBUTING.md for more details.)

@gmlewisgmlewis changed the title feat: add link to bored-engineer/github-conditional-http-transport to conditional requests documentationfeat: Add link to bored-engineer/github-conditional-http-transport to conditional requests documentationFeb 8, 2025
Comment threadREADME.md Outdated
Comment threadgithub/doc.go Outdated

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bored-engineer!
LGTM.
Merging.

@gmlewis
gmlewis merged commit ef0b26b into google:masterFeb 8, 2025
@bored-engineer
bored-engineer deleted the patch-2 branch February 8, 2025 20:59
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: recommend bored-engineer/github-conditional-http-transport for conditional requests

2 participants

@bored-engineer@gmlewis